bugGNU Astronomy Utilities - Bugs: bug #48611, Buffer to copy non-directory part...


You are not allowed to post comments on this tracker with your current authentication level.

bug #48611: Buffer to copy non-directory part is too small

Submitter:  Vladimir Markelov <vvm>
Submitted:  Sun 24 Jul 2016 02:24:33 AM UTC
Category:  Libraries Severity:  2 - Minor
Item Group:  Source code Status:  Fixed
Privacy:  Public Assigned to:  vvm
Open/Closed:  Closed

Mon 25 Jul 2016 12:10:16 AM UTC, comment #5: 

Thanks a lot. It has been merged with master and pushed onto the main repository.

Mohammad Akhlaghi <makhlaghi>
Group administrator
Mon 25 Jul 2016 12:02:24 AM UTC, comment #4: 

Change commit description: make all lines shorter than 75 characters:

Vladimir Markelov <vvm>
Sun 24 Jul 2016 11:13:39 PM UTC, comment #3: 

I corrected the patch description - no code changes.
New link to changed commit:

Vladimir Markelov <vvm>
Sun 24 Jul 2016 11:10:15 AM UTC, comment #2: 

Great correction, thank you.

I don't know if you noticed my comments on your previous commits. So I am repeating them again here. I would be most grateful if you could correct the commit message (with 'git commit --amend' for example) and comment here when its done so I can merge it into master.

  • Start the commit message title with a capital letter.

  • Do not include the bug number in the title. It is included in some merge commit titles since they are just a merge and no change in the files has actually been done.

  • In one case (commit 70e7da4) the title was a little too long. Try to keep the titles within 50 characters ;-).

  • Please be very descriptive in the commit body (even more than here on Savannah when reporting or fixing the bug). This is very important for others to be able to understand your work later (and also for the developers). For example I had to compare the code changes to the webpage/email to understand it. If you elaborate in the commit message, a "git log -p" will be enough for any developer to understand much more easier.


  • Add a "This fixed bug #XXXXX." or "This finishes task #ID." after the commit message body.
Mohammad Akhlaghi <makhlaghi>
Group administrator
Sun 24 Jul 2016 02:38:28 AM UTC, comment #1: 
Vladimir Markelov <vvm>
Sun 24 Jul 2016 02:24:33 AM UTC, original submission:  

Off-by-one error. No space for ending '\0':

  out=malloc(l*sizeof *out);
    error(EXIT_FAILURE, errno, "%lu bytes for notdir", l*sizeof *out);
strcpy(out, tmp);

Vladimir Markelov <vvm>


(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -email is unavailable- added by makhlaghi (Posted a comment)
  • -email is unavailable- added by vvm (Submitted the item)

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.


    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-07-25 makhlaghi StatusIn Progress Fixed
        Open/ClosedOpen Closed
    2016-07-24 vvm StatusNone In Progress
        Assigned toNone vvm

    Back to the top

    Powered by Savane 3.13-b921.
    Corresponding source code