bugGNU Astronomy Utilities - Bugs: bug #48611, Buffer to copy non-directory part...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #48611: Buffer to copy non-directory part is too small

Submitted by:  Vladimir Markelov <vvm>
Submitted on:  Sun 24 Jul 2016 02:24:33 AM UTC  
 
Category: LibrariesSeverity: 2 - Minor
Item Group: Source codeStatus: Fixed
Privacy: PublicAssigned to: Vladimir Markelov <vvm>
Open/Closed: Closed

Mon 25 Jul 2016 12:10:16 AM UTC, comment #5:

Thanks a lot. It has been merged with master and pushed onto the main repository.

Mohammad Akhlaghi <makhlaghi>
Project Administrator
Mon 25 Jul 2016 12:02:24 AM UTC, comment #4:

Change commit description: make all lines shorter than 75 characters:
https://github.com/VladimirMarkelov/gnuastro-vvm/commit/6c6c6ddec4c8e765a6dcb9a5a916f06df03ec587

Vladimir Markelov <vvm>
Project MemberIn charge of this item.
Sun 24 Jul 2016 11:13:39 PM UTC, comment #3:

I corrected the patch description - no code changes.
New link to changed commit:
https://github.com/VladimirMarkelov/gnuastro-vvm/commit/9c29fdfaf9b503f687df05835f63ffc550115594

Vladimir Markelov <vvm>
Project MemberIn charge of this item.
Sun 24 Jul 2016 11:10:15 AM UTC, comment #2:

Great correction, thank you.

I don't know if you noticed my comments on your previous commits. So I am repeating them again here. I would be most grateful if you could correct the commit message (with 'git commit --amend' for example) and comment here when its done so I can merge it into master.

  • Start the commit message title with a capital letter.
  • Do not include the bug number in the title. It is included in some merge commit titles since they are just a merge and no change in the files has actually been done.
  • In one case (commit 70e7da4) the title was a little too long. Try to keep the titles within 50 characters ;-).
  • Please be very descriptive in the commit body (even more than here on Savannah when reporting or fixing the bug). This is very important for others to be able to understand your work later (and also for the developers). For example I had to compare the code changes to the webpage/email to understand it. If you elaborate in the commit message, a "git log -p" will be enough for any developer to understand much more easier.
  • Add a "This fixed bug #XXXXX." or "This finishes task #ID." after the commit message body.
Mohammad Akhlaghi <makhlaghi>
Project Administrator
Sun 24 Jul 2016 02:38:28 AM UTC, comment #1:

Please see the patch at repository branch:
https://github.com/VladimirMarkelov/gnuastro-vvm/tree/bug-48611-library

Commit:
https://github.com/VladimirMarkelov/gnuastro-vvm/commit/05c37c37bcdade7664d7095ee8a83739d1973e5f

Vladimir Markelov <vvm>
Project MemberIn charge of this item.
Sun 24 Jul 2016 02:24:33 AM UTC, original submission:

Off-by-one error. No space for ending '\0':

l=strlen(tmp);
errno=0;
out=malloc(lsizeof out);
if(out==NULL)
error(EXIT_FAILURE, errno, "%lu bytes for notdir", lsizeof out);
strcpy(out, tmp);

Vladimir Markelov <vvm>
Project MemberIn charge of this item.

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by makhlaghi (Posted a comment)
  • -unavailable- added by vvm (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 25 Jul 2016 12:10:16 AM UTCmakhlaghiStatusIn Progress=>Fixed
      Open/ClosedOpen=>Closed
    Sun 24 Jul 2016 02:35:30 AM UTCvvmStatusNone=>In Progress
      Assigned toNone=>vvm

    Back to the top


    Powered by Savane 3.1-cleanup1