bugmake - Bugs: bug #48009, Increased stack rlimit is...

 
 

bug #48009: Increased stack rlimit is inherited by the subprocesses to make when make restarts

Submitter:  Jeremy Devenport <jeremyd>
Submitted:  Wed 25 May 2016 12:00:19 PM UTC
   
 
Severity:  3 - Normal Item Group:  Bug
Status:  Fixed Privacy:  Public
Assigned to:  psmith Open/Closed:  Closed
Component Version:  4.2.1 Operating System:  POSIX-Based
Fixed Release:  4.2.1 Triage Status:  Small Effort
* Mandatory Fields

Add a New Comment Rich Markup
   

Tue 31 May 2016 07:16:31 AM UTC, comment #1: 

Fixed for the next release.  Thanks for the report.

Paul D. Smith <psmith>
Group administrator
Wed 25 May 2016 12:00:19 PM UTC, original submission:  

The fix for https://savannah.gnu.org/bugs/?22010 is incomplete. When make restarts itself due to an updated makefile it re-exec's itself inheriting the increased stack rlimit but without remembering the original saved values so the re-exec'd make will run its subprocesses with the increased stack limit.

This sequence of commands demonstrates the bug:

$ ulimit -H -s 
32768
$ ulimit -s    
4096
$ cat Makefile
include foo.inc
foo.inc: bar.txt
        touch $@
show-stack-rlimit:
        ulimit -s
$ echo > foo.inc
$ echo > bar.txt
$ make show-stack-rlimit
touch foo.inc
ulimit -s
32768    <-- inherited the stack increase to the hard limit
$ make show-stack-rlimit
ulimit -s
4096

The attached patch resolves the issue for me.

Jeremy Devenport <jeremyd>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by psmith (Posted a comment)
  • -email is unavailable- added by jeremyd (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-05-31 psmith StatusNone Fixed
        Assigned toNone psmith
        Open/ClosedOpen Closed
        Fixed ReleaseNone 4.2.1
        Triage StatusNone Small Effort
    2016-05-25 jeremyd Attached File- Added stack-rlimit-make-restart.patch, #37259

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code