bugGNU cpio - Bugs: bug #46638, HOL_ENTRY_PTRCMP triggers...


bug #46638: HOL_ENTRY_PTRCMP triggers undefined behavior

Submitted by:  None
Submitted on:  Tue 08 Dec 2015 09:44:59 PM UTC  
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: None
Privacy: PublicAssigned to: None
Open/Closed: Open

Add a New Comment(Rich Markup)

You are not logged in

Please log in, so followups can be emailed to you.


Tue 08 Dec 2015 09:44:59 PM UTC, original submission:

HOL_ENTRY_PTRCMP macro (used by hol_entry_cmp) returns 1 for equal arguments. This violates requirements to qsort's comparison function (which must be a total ordering) and causes UB at runtime. In practice this may mean strange runtime misbehaviors.

The issue can be easily fixed by slightly more elaborate code: ((a)->ord < (b)->ord ? -1 : (a)->ord > (b)->ord ? 1 : 0).

This issue was detected with automated qsort verification tool SortChecker (https://github.com/yugr/sortcheck).



(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):

No files currently attached


Depends on the following items: None found

Items that depend on this one: None found


CC list is empty


Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.


Please enter the title of George Orwell's famous dystopian book (it's a date):



No Changes Have Been Made to This Item

Back to the top

Powered by Savane 3.1-cleanup1