bugDenemo - Bugs: bug #46376, denemo-2.0.0 fails to compile/link

 
 

bug #46376: denemo-2.0.0 fails to compile/link

Submitter:  Timo Gurr <tgurr>
Submitted:  Wed 04 Nov 2015 10:44:58 AM UTC
   
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  None
Originator Name:  Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Tue 16 Feb 2016 02:47:28 PM UTC, comment #9: 

Your build will have worked but resulted in a crippled Denemo with no display of the typeset score. The configure.ac file was at fault and has now been fixed with commit
fca62f292328bcd5a588a01d9ac5c226a17dd64a

see the bug #47155 for more details.

Richard Shann <rshann>
Group administrator
Wed 04 Nov 2015 04:37:53 PM UTC, comment #8: 

It's Exherbo Linux (https://exherbo.org/), a project started by former Gentoo developers some years ago.

Timo Gurr <tgurr>
Wed 04 Nov 2015 04:19:53 PM UTC, comment #7: 

I'm very glad to hear it, though I don't understand why - I build many times a day with evince enabled...
Anyway, life is too short to investigate these things. What is the system you build for I wonder?

Richard Shann <rshann>
Group administrator
Wed 04 Nov 2015 04:12:46 PM UTC, comment #6: 

Thank you very much! With the patch I'm able to build denemo-2.0.0 fine now, it works with either the evince option enabled or disabled.

Timo Gurr <tgurr>
Wed 04 Nov 2015 03:40:07 PM UTC, comment #5: 

I've reviewed the code and can see a discrepancy involving precisely those functions complained of. I've pushed a commit to git that fixes the discrepancy. Even though I don't understand what your system is doing, this should fix the problem.

author Richard Shann <richard.shann@virgin.net>
Wed, 4 Nov 2015 15:25:32 +0000 (15:25 +0000)
committer Richard Shann <richard.shann@virgin.net>
Wed, 4 Nov 2015 15:25:32 +0000 (15:25 +0000)


diff --git a/src/export/print.c b/src/export/print.c
index 0c96e97..d01541c 100644 (file)
--- a/src/export/print.c
+++ b/src/export/print.c
@@ -544,6 +544,9 @@ create_pdf (gboolean part_only, gboolean all_movements)
 
 void create_pdf_for_lilypond (gchar *lilypond)
 {
+#ifndef USE_EVINCE 
+          g_debug("This feature requires denemo to be built with evince");
+#else
          if (get_print_status()->printpid != GPID_NONE)
     {
       if (confirm (("Already Typesetting"), ("Abandon this typeset?")))
@@ -567,6 +570,7 @@ void create_pdf_for_lilypond (gchar *lilypond)
   get_print_status()->invalid = 0;
   run_lilypond_for_pdf (filename, lilyfile); 
   g_child_watch_add (get_print_status()->printpid, (GChildWatchFunc) printview_finished, (gpointer) (FALSE));
+#endif
 }
 /**
  * Dialog function used to select measure range
diff --git a/src/ui/markup.c b/src/ui/markup.c
index 9116401..0c99424 100644 (file)
--- a/src/ui/markup.c
+++ b/src/ui/markup.c
@@ -240,7 +240,11 @@ static gboolean keypress_callback (G_GNUC_UNUSED GtkWidget w, GdkEventKey ev
 
 gboolean get_user_markup (GString user_text, GString *marked_up_text, gchar title, char *instruction, gchar *initial_value, gboolean modal, gboolean format_only)
 {
+#ifndef USE_EVINCE 
+          g_debug("This feature requires denemo to be built with evince");
+#else
   implement_show_print_view (FALSE);
+#endif
   GtkWidget *hbox = gtk_hbox_new (FALSE, 8);
   GtkWidget *button = gtk_button_new_with_label (_("Paste Current Snippet"));
   gtk_widget_set_tooltip_text (button, _("Pastes the music captured in the currently selected Snippet into the text at the cursor.\nThe music appears here in the LilyPond syntax.\nIt will print as typeset music embedded in the sentence you are writing.\nYou can edit the syntax following the LilyPond syntax.\n"));

Richard Shann <rshann>
Group administrator
Wed 04 Nov 2015 12:59:42 PM UTC, comment #4: 

Thanks for investigating.

The users are able to easily set that options:

These are the actions I will take, in order:

u   media-sound/denemo:0::media 2.0.0 to ::installed replacing 1.2.4-r1
    -alsa -doc evince* -gtk-doc -jack build_options: symbols=strip jobs=5 -dwarf_compress (-recommended_tests) -trace work=tidyup
    Reasons: target

However we generally have the rule to follow upstream suggestions and provide sane defaults instead of offering the possibility to enable/disable every possible configure switch. I didn't create the initial "package" and I don't use Denemo myself so I can't really judge about that feature personally. If Denemo will be crippled and pretty much useless without that feature I might remove that option and just hard-enable it.

As for the error, I'm afraid I'm running into it as well with the evince option enabled (--enable-evince).

Timo Gurr <tgurr>
Wed 04 Nov 2015 12:40:58 PM UTC, comment #3: 

Sorry, I'm sure you are right. It was your comment that 1.2.4 was fine that sparked that comment. I'm only hazily remembering having seen this. Now I think more on it, I think perhaps I have seen it reported by someone trying to build for themselves.
Looking at your log, it seems like you are configuring with --disable-evince
this would tie in with the compile time error: if some extra code has been added since 1.2.4 that should not be there if evince is not available then that would explain it.
64,000 question: why does this option to disable evince exist? The program is AFAIK pretty much useless without it.
I'll look into what may be causing that, but please examine why you would want Denemo built without anything to show the typeset score, which is the main point of the program.

Richard Shann <rshann>
Group administrator
Wed 04 Nov 2015 12:02:54 PM UTC, comment #2: 

I'm not sure how that could help. We're a source-based distribution and our package manager grabs the upstream provided tarball and initiates a build, so the build environment on every run is already fresh and clean. I'm attaching a full build log.

(file #35382)

Timo Gurr <tgurr>
Wed 04 Nov 2015 10:47:47 AM UTC, comment #1: 

you need a make distclean I think.
I hit this from time to time - start afresh!

Richard Shann <rshann>
Group administrator
Wed 04 Nov 2015 10:44:58 AM UTC, original submission:  

While Denemo 1.2.4 compiles, installs and works fine, I get the following error with Denemo 2.0.0.

Makefile:771: recipe for target 'denemo' failed
make[2]: Leaving directory '/var/tmp/paludis/build/media-sound-denemo-2.0.0/work/denemo-2.0.0/src'
Makefile:618: recipe for target 'all-recursive' failed
make[1]: Leaving directory '/var/tmp/paludis/build/media-sound-denemo-2.0.0/work/denemo-2.0.0'
Makefile:526: recipe for target 'all' failed
print.o: In function `create_pdf_for_lilypond':
print.c:(.text+0xc25): undefined reference to `printview_finished'
markup.o: In function `get_user_markup':
markup.c:(.text+0x9b9): undefined reference to `implement_show_print_view'
collect2: error: ld returned 1 exit status
make[2]: * [denemo] Error 1
make[1]: * [all-recursive] Error 1
make: * [all] Error 2

The installed lilypond version is 2.18.2.

Timo Gurr <tgurr>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #35382:  1446638427-install-media-sound_denemo-2.0.0:0::media.out added by tgurr (718KiB - application/octet-stream - build.log)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rshann (Posted a comment)
  • -email is unavailable- added by tgurr (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-11-04 rshann StatusNone Fixed
        Open/ClosedOpen Closed
    2015-11-04 tgurr Attached File- Added 1446638427-install-media-sound_denemo-2.0.0:0::media.out, #35382

    Back to the top

    Powered by Savane 3.13-caa5.
    Corresponding source code