bugGNU Gengetopt - Bugs: bug #46354, gm.cc:266: bad if test ?

 
 

bug #46354: gm.cc:266: bad if test ?

Submitter:  David Binderman <dcb314>
Submitted:  Sun 01 Nov 2015 05:20:23 PM UTC
   
 
Category:  None Severity:  4 - Important
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  gscano
Originator Name:  Open/Closed:  Open
* Mandatory Fields

Add a New Comment Rich Markup
   

Fri 27 Nov 2020 05:48:02 AM UTC, comment #1: 

It was indeed a bad test condition, thanks!

Gr├ęgoire Scano <gscano>
Group Member
Sun 01 Nov 2015 05:20:23 PM UTC, original submission:  

gm.cc:266:35: warning: logical 'or' of collectively exhaustive tests is always true [-Wlogical-op]

Source code is

     if (opt->type != ARG_FLAG || opt->type != ARG_NO) {

Maybe better code

     if (opt->type != ARG_FLAG && opt->type != ARG_NO) {

David Binderman <dcb314>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gscano (Updated the item)
  • -email is unavailable- added by dcb314 (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-11-27 gscano StatusConfirmed Fixed
    2020-11-27 gscano Severity3 - Normal 4 - Important
        StatusNone Confirmed
        Assigned toNone gscano

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code