bugGNU Astronomy Utilities - Bugs: bug #46225, Programs don't depend on libs in...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #46225: Programs don't depend on libs in Makefiles

Submitter:  Mosè Giordano <giordano>
Submitted:  Fri 16 Oct 2015 12:35:35 PM UTC
   
 
Category:  Installation Severity:  3 - Normal
Item Group:  Configuration file Status:  Fixed
Privacy:  Public Assigned to:  alteholz
Open/Closed:  Closed

Fri 02 Feb 2024 02:44:34 PM UTC, comment #3: 

Thanks a lot for the interesting fix ;-)! It has been merged into the 'master' branch as Commit e398df6e.

The extra compilation of all the programs that you mentioned in the commit message is indeed a problem, but as I have added in the commit message, fortunately in Gnuastro we have a set of '--enable-*' configure-time options to only build a sub-set of the programs (that are necessary during development, when this becomes a problem).

Mohammad Akhlaghi <makhlaghi>
Group administrator
Wed 24 Jan 2024 06:09:17 AM UTC, comment #2: 
Thorsten Alteholz <alteholz>
Group Member
Mon 15 Jan 2024 05:50:37 PM UTC, comment #1: 

While looking at another bug, I also stumbled upon this issue.

When adding "-lgnuastro" to _LDADD, this is used as a linker flag and just passed to ld. When adding a direct path to libgnuastro.la, like $(top_builddir)/lib/libgnuastro.la, the makefile is able to add a real dependency. Now changes to libgnuastro.la will result in relinking of the binaries in bin/

Unfortunately this requires more CPU cycles as every binary has to be relinked. But as this bug shows, this is the more expected behaviour of the build process.

So I propose the commit at

https://git.alteholz.dev/alteholz/gnuastro/-/commit/f03990eafc362024d7248f3cda8a316ec02ab894

as a fix for this bug.

Any comments?

Thorsten Alteholz <alteholz>
Group Member
Fri 16 Oct 2015 12:35:35 PM UTC, original submission:  

In any Makefile programs programs depend on libraries under lib/, thus changing them doesn't trigger re-compilation of programs.

Mosè Giordano <giordano>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by makhlaghi (Posted a comment)
  • -email is unavailable- added by alteholz (Posted a comment)
  • -email is unavailable- added by giordano (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2024-02-02 makhlaghi StatusNone Fixed
        Assigned toNone alteholz
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-04b1.
    Corresponding source code