bugGNU Screen - Bugs: bug #43224, Patches for installation

 
 

bug #43224: Patches for installation

Submitted by:  Maarten ter Huurne <maartenth>
Submitted on:  Mon 15 Sep 2014 02:29:59 AM UTC  
 
Category:  Build/Install Severity:  3 - Normal
Priority:  5 - Normal Status:  None
Privacy:  Public Assigned to:  None
Open/Closed:  Open Release:  4.2.1
Fixed Release:  None Planned Release:  None
Work Required:  None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 15 Sep 2014 02:29:59 AM UTC, original submission:

Attached patches 0006 and 0008 make the life of a packager a bit easier, by making Screen act more like typical packages: no backups made on install and an option to override binary versioning.

Patch 0007 will attempt chmod even if chown fails. When packaging, it is typical to install as a non-root user using DESTDIR. What I am unsure of though is whether having a setuid Screen binary by default is actually a good idea. But that is what the installer does when run as root, so I guess it makes sense to make non-root installs as similar as possible. An alternative would be to skip the setuid as part of "make install" and instead instruct the user/packager to change permissions if their use of Screen requires it.

Patch 0009 fixes an issue with parallel builds (make -j2), so I would recommend to apply at least that one.

Maarten ter Huurne <maartenth>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #32101:  0006-Do-not-create-backup-of-old-installed-binary.patch added by maartenth (2KiB - application/octet-stream - git formatted patches)
file #32102:  0008-Support-overriding-SCREEN-to-get-a-non-versioned-bin.patch added by maartenth (1KiB - application/octet-stream - git formatted patches)
file #32103:  0007-Change-binary-permission-flags-even-if-chown-fails.patch added by maartenth (1KiB - application/octet-stream - git formatted patches)
file #32104:  0009-Ensure-that-installation-dirs-exist-before-copying-f.patch added by maartenth (2KiB - application/octet-stream - git formatted patches)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by maartenth (Submitted the item)
  • -email is unavailable- added by maartenth
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-09-15 maartenth Attached File- => Added 0006-Do-not-create-backup-of-old-installed-binary.patch, #32101
        Attached File- => Added 0008-Support-overriding-SCREEN-to-get-a-non-versioned-bin.patch, #32102
        Attached File- => Added 0007-Change-binary-permission-flags-even-if-chown-fails.patch, #32103
        Attached File- => Added 0009-Ensure-that-installation-dirs-exist-before-copying-f.patch, #32104
        Carbon-Copy- => Added maartenth

    Back to the top


    Powered by Savane 3.3