bugLibreJS - Bugs: bug #42888, LibreJS fails to detect licenses...

 
 

bug #42888: LibreJS fails to detect licenses with JS Web Labels for certain scripts.

Submitted by:  Loic Duros <lduros>
Submitted on:  Thu 31 Jul 2014 03:38:42 PM UTC  
 
Category: NoneSeverity: 5 - Blocker
Item Group: NoneStatus: None
Privacy: PublicAssigned to: Nik Nyby <nikolas>
Open/Closed: Open

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 08 Aug 2014 07:39:06 AM UTC, comment #1:

There are two separate issues here:

- error parsing: Error: already being checked.
This is probably narcissus not parsing the code correctly. We need to make this more robust. I haven't fixed this yet.

The second issue is the one I was seeing on rootstrikers.org after working around the parse bug by making the javascript more correct. It still wasn't accepting all.min.js as free even though there was an entry for it in the jslicense table, it just said it was nontrivial, nonfree.

My change in r1188 fixes the issue for me:
http://bzr.savannah.gnu.org/lh/librejs/dev/revision/1188

The licenselist wasn't properly getting passed from the WebLabelFinder to DomHandler.lookForJsWebLabels. I'm not sure why it was an issue only for this particular script. Maybe since it was so large it hit some timeout in the callbacks.

Nik Nyby <nikolas>
Project AdministratorIn charge of this item.
Thu 31 Jul 2014 03:38:42 PM UTC, original submission:

LibreJS fails to detect licenses with JS Web Labels for certain scripts.

Example errors:
NONTRIVIAL: eval has been found in code
http://www.rootstrikers.org/vendor/underscore.js

error parsing: Error: already being checked.
http://www.rootstrikers.org/app/scripts/all.min.js

The JS Web Labels page is correctly set up and other scripts are properly detected.

Loic Duros <lduros>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by nikolas (Updated the item)
  • -unavailable- added by lduros (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follows 1 latest change.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 08 Aug 2014 05:24:57 AM UTCnikolasAssigned toNone=>nikolas

    Back to the top


    Powered by Savane 3.1-cleanup1