bugmake - Bugs: bug #42695, Error compiling make from last git...

 
 

bug #42695: Error compiling make from last git in Windows

Submitted by:  Fabio <oldfaber>
Submitted on:  Mon 07 Jul 2014 03:27:43 PM UTC  
 
Severity:  3 - Normal Item Group:  Build/Install
Status:  Fixed Privacy:  Public
Assigned to:  None Open/Closed:  Closed
Component Version:  4.1 Operating System:  MS Windows
Fixed Release:  4.1 Triage Status:  Small Effort

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 16 Jul 2014 03:51:58 PM UTC, comment #4: 

It's not THAT important, but I like to do a filever -v xxx.exe
and see the version, if it's a debug build, and more. Or see the same informations in the Version tab of the file properties, or
see the product name in Process Explorer.
The .rc file is 52 lines altogher and may live in the w32 directory. It uses config.h to get the version.

The Nmakefile patch is only useful if the resource file is used.

I use another small patch for Microsoft compiler:
changing some lines, i.e.
    "$(LINK.o) $^ $(LOADLIBES) $(LDLIBS) -o $@",
to
    "$(LINK.o) $^ $(LOADLIBES) $(LDLIBS) $(OUTPUT_OPTION)",
in default.c. Then putting in the Makefiles
OUTPUT_OPTION=
silences the "-o option is obsolete" that cl spits out,
and allows me to use the -link options.
Could it be of general interest ? It does not change the default
rules because OUTPUT_OPTION is already "-o $@"

Regards.

Fabio

Fabio <oldfaber>
Wed 16 Jul 2014 03:26:10 PM UTC, comment #3: 

Thanks, I fixed that in 241787d.

Why is the RC file important?  IME, maintaining such Windows specific files is a nuisance in the long run, as they fall out of sync.

Please send the patch for NMakefile.template.

Thanks.

Eli Zaretskii <eliz>
Project Member
Wed 16 Jul 2014 12:42:51 PM UTC, comment #2: 

Hi all,

thank you for the fix, but it's not enough.
A similar fix is needed in the external declaration of
program in makeint.h at line 612.

I created a small .rc file for make.exe that I could send as
public domain and maybe adopted and included in Gnu make.
Are you interested in it ?
It also needs a small modification to NMakefile.template
to be compiled and used.

Regards

Fabio

Fabio <oldfaber>
Sat 12 Jul 2014 10:06:00 AM UTC, comment #1: 

Thanks, I fixed this in faeeb27166942f6841a408ef22192153ff0cb253.

Eli Zaretskii <eliz>
Project Member
Mon 07 Jul 2014 03:27:43 PM UTC, original submission:  

Git commit ac67346d0fb5e "Improve constification of the codebase"
breaks compilation on Windows (at least).

The problem is in main.c:486
const char *program

and line 1187 of main.c
                program[argv0_len - 4] = '\0';
tries to change a const object.

Thank you.

Fabio

Fabio <oldfaber>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by eliz (Posted a comment)
  • -email is unavailable- added by oldfaber (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-07-12 eliz Item GroupNone => Build/Install
        StatusNone => Fixed
        Open/ClosedOpen => Closed
        Component VersionNone => 4.1
        Fixed ReleaseNone => 4.1
        Triage StatusNone => Small Effort

    Back to the top


    Powered by Savane 3.5