bugmake - Bugs: bug #42447, Fix exporting symbols for...

 
 

bug #42447: Fix exporting symbols for recursive make on VMS.

Submitted by:  John Malmberg <wb8tyw>
Submitted on:  Wed 28 May 2014 05:00:20 AM UTC  
 
Severity: 3 - NormalItem Group: Bug
Status: NonePrivacy: Public
Assigned to: NoneOpen/Closed: Open
Component Version: 4.0Operating System: VMS
Fixed Release: NoneTriage Status: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 14 Jun 2014 04:47:10 PM UTC, comment #1:

Uploaded replacement patch:

  • Updated the Git description to match format in git logs.
  • Added vms_exit.c missing from previous patch needed for this to be applied against master.
  • Found that when make was reading DCL symbols and logical names as environment variables, it was doubling the "$" characters found. This means that the export routine has to remove the duplicate "$" characters before creating the symbol.

This patch also includes the fix for exit decoding that has been discussed on the bug-make list.

The program name is created as the equivalent of a shell alias instead of using the alternate "MCR make-name" syntax so that when the macro is expanded, no spaces are present. While it is not known that having a space there would cause a problem, I feel that there is a high risk of that.

The DCL symbol export is used instead of putting the symbols in the helper command procedure and always using a command procedure to try to have the program use as similar program flows to make to get the tests working.

It also seems to me to be more efficient to try to avoid using the helper command procedure as much as possible.

I am expecting that changes will be needed in the VMS specific command launching to support multiple jobs, One shell, and the issue of using the command file or a pool of subprocesses can be addressed them.

Copyright assignment papers are on file with fsf.org.

(file #31546)

John Malmberg <wb8tyw>
Wed 28 May 2014 05:00:20 AM UTC, original submission:

This patch fixes Make on VMS to export symbols so that recursive and nested make commands will work.

This also exports a foreign command for the make image that was run.

Some of the tests still fail because VMS currently does not do shell expansion of exported symbols. I will be looking at adding that capability in the future as part of improving posix shell simulation.

John Malmberg <wb8tyw>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #31546:  0001-vms_export_symbol_fix_pass2.patch added by wb8tyw (46kB - application/octet-stream - Updated export fix and add missing vms_exit.c)
file #31460:  0001-vms_export_symbol_fix_pass1.patch added by wb8tyw (41kB - application/octet-stream - Make exporting symbols work on VMS for recursive make.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by wb8tyw (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 14 Jun 2014 04:47:10 PM UTCwb8tywAttached File-=>Added 0001-vms_export_symbol_fix_pass2.patch, #31546
    Wed 28 May 2014 05:00:20 AM UTCwb8tywAttached File-=>Added 0001-vms_export_symbol_fix_pass1.patch, #31460

    Back to the top


    Powered by Savane 3.1-cleanup