bugmake - Bugs: bug #40790, --enable-load in make 4.0 should...

 
 

bug #40790: --enable-load in make 4.0 should auto-disable itself when no dlopen found

Submitted by:  Alan Hourihane <alanh>
Submitted on:  Tue 03 Dec 2013 04:01:51 PM UTC  
 
Severity:  3 - Normal Item Group:  Build/Install
Status:  Fixed Privacy:  Public
Assigned to:  Paul D. Smith <psmith> Open/Closed:  Closed
Component Version:  4.0 Operating System:  POSIX-Based
Fixed Release:  4.1 Triage Status:  Verified

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 18 Jan 2014 09:54:20 PM UTC, comment #3: 

I fixed the variable name errors, but left the rest in.  The message is only printed if BOTH (a) the load support is not available, AND (b) the user explicitly asked for it by adding --enable-load on the command line.  In that case I think it's right to tell them that their specific request was not achievable.

However, if you just run "./configure" without explicit --enable-load and load support is not available, it won't print any notes about load support.

Paul D. Smith <psmith>
Project AdministratorIn charge of this item.
Sun 12 Jan 2014 10:02:00 PM UTC, comment #2: 

It was just extra changes I made as I didn't see the need to tell the user about things.

Alan Hourihane <alanh>
Sun 12 Jan 2014 09:20:10 PM UTC, comment #1: 

Hi Alan; thanks for the patch.  I see the error with using the wrong ac_* variables; good catch on that.  However, I'm not sure why some of the other changes were made.  For example, changing the AS_CASE from "any value is a no" to "all values must be yes", and removing the echoed warning at the end.

Did these cause problems for you, or was that just extra change you made in addition?

Paul D. Smith <psmith>
Project AdministratorIn charge of this item.
Tue 03 Dec 2013 04:01:51 PM UTC, original submission:  

If dlopen is not found during configure, and --enable-load was given then make should turn off this option as if --disable-load was given.

Alan Hourihane <alanh>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #29777:  configure.ac.patch added by alanh (1KiB - text/x-patch - Correct patch, don't use the #29776.)
file #29776:  configure.ac.patch added by alanh (1KiB - text/x-patch - Patch to fix.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by psmith (Posted a comment)
  • -email is unavailable- added by alanh (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 10 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-01-18 psmith StatusNone => Fixed
        Open/ClosedOpen => Closed
        Operating SystemNone => POSIX-Based
        Fixed ReleaseNone => 4.1
    2014-01-12 psmith Item GroupNone => Build/Install
        Assigned toNone => psmith
        Component VersionNone => 4.0
        Triage StatusNone => Verified
    2013-12-03 alanh Attached File- => Added configure.ac.patch, #29777
    2013-12-03 alanh Attached File- => Added configure.ac.patch, #29776

    Back to the top


    Powered by Savane 3.5