bugPSPP - Bugs: bug #38922, Row Header button selects wrong...

 
 

bug #38922: Row Header button selects wrong row if leftclick precedes rightclick

Submitter:  John Darrington <jmd>
Submitted:  Tue 07 May 2013 11:05:24 AM UTC
   
 
Category:  Graphical User Interface Severity:  7 - Major
Status:  Fixed Assigned to:  None
Open/Closed:  Closed Release:  Before 0.8.0
Effort:  0.00
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 09 May 2013 04:11:06 AM UTC, comment #4: 

I pushed what I hope is a better fix.

Ben Pfaff <blp>
Group administrator
Wed 08 May 2013 06:27:59 AM UTC, comment #3: 

This fix seems to address the symptom.  But unfortunately another has appeared:

If I follow the procedure to reproduce the initial symptom, and repeat 4 times.  After the fourth attempt I see:

Gdk-WARNING **: losing last reference to undestroyed window
Gdk-CRITICAL **: gdk_window_get_toplevel: assertion `GDK_IS_WINDOW (window)' failed
GLib-GObject-CRITICAL **: g_object_ref: assertion `G_IS_OBJECT (object)' failed
Gdk-CRITICAL **: gdk_drawable_get_display: assertion `GDK_IS_DRAWABLE (drawable)' failed


And then the program crashes.

John Darrington <jmd>
Group administrator
Wed 08 May 2013 05:31:00 AM UTC, comment #2: 

I pushed a fix.

Ben Pfaff <blp>
Group administrator
Wed 08 May 2013 05:24:32 AM UTC, comment #1: 

The problem is that when there's a PsppireCellRendererButton involved (e.g. when you click on the cell), the GdkEventButton that the button-press-event contains has x and y coordinates related to the button, as passed to psppire_cell_renderer_button_press_event().  That function tries to propagate the event up in the widget hierarchy with g_signal_stop_emission_by_name(), which works OK except that the x and y coordinates are wrong.

I'm not sure whether the solution is to have the datasheet intercept button-press-events on the PsppireCellRendererButton or to have PsppireCellRendererButton translate coordinates before it propagates the event upward.

Ben Pfaff <blp>
Group administrator
Tue 07 May 2013 11:05:24 AM UTC, original submission:  

1. Open a dataset with at least two cases.
2. Switch to the Data View
3. Place the pointer over (say) the tenth row header button.
4. Click the left mouse button.
5. Click the right mouse button.
6. The popup menu appears (as it should), but  row 1 gets selected instead of row 10.

This is especially annoying if the user is deleting cases, since she will inadvertently delete the wrong case (and we don't yet have an undo button).

John Darrington <jmd>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by blp (Posted a comment)
  • -email is unavailable- added by jmd (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2013-05-09 blp Open/ClosedOpen Closed
    2013-05-08 jmd Open/ClosedClosed Open
    2013-05-08 blp StatusNone Fixed
        Open/ClosedOpen Closed
    2013-05-07 jmd ReleaseNone Before 0.8.0

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code