bugXBoard - Bugs: bug #37210, Mishandling of X11 -I flags

 
 

bug #37210: Mishandling of X11 -I flags

Submitted by:  Daniel Macks <dmacks>
Submitted on:  Tue 28 Aug 2012 03:31:19 PM UTC  
 
Category:  XBoard (X11) Severity:  3 - Normal
Item Group:  Installation/Configuration/Packaging Status:  Fixed
Assigned to:  Arun Persaud <apersaud> Open/Closed:  Closed
Release:  git

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 29 Aug 2012 04:30:25 AM UTC, comment #1:

Thanks for the patch, I applied it (added once missing save_cppflags="$CPPFLAGS" in the last hunk). Let me know if this solves the problem and then I'll close the bug report

Arun Persaud <apersaud>
Project AdministratorIn charge of this item.
Tue 28 Aug 2012 03:31:19 PM UTC, original submission:

A fink user reported that building xboard on OS X 10.8 failed to find the Xt headers. Apple (or XQuartz, not sure how far up the vendor tree this goes) formerly supplied a /usr/include/X11 -> /usr/X11 symlink but no longer does. As a result, AC_CHECK_HEADER no longer finds x11 headers because they are not in the default search paths. The standard x11 detection mechanism succeeds and finds the needed additional -I flags, but then configure.ac does not use them when doing its own tests.

Here is the good way (from xboard-4.5.2a line 350):

save_cflags="$CFLAGS"
CFLAGS="$CFLAGS $X_CFLAGS"
CPPFLAGS="$CPPFLAGS $X_CFLAGS"
AC_CHECK_HEADERS(X11/xpm.h)
CFLAGS="$save_cflags"

(though it probably should save and restore CPPFLAGS also?)

Lines 128 and 154 each fail because they don't propagate X_CFLAGS.

Daniel Macks <dmacks>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #26437:  x11-flag-propagation.patch added by dmacks (1KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by apersaud (Posted a comment)
  • -email is unavailable- added by dmacks (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-09-13 apersaud StatusReady For Test => Fixed
        Open/ClosedOpen => Closed
        ReleaseNone => git
    2012-08-29 apersaud StatusNone => Ready For Test
        Assigned toNone => apersaud
    2012-08-28 dmacks Attached File- => Added x11-flag-propagation.patch, #26437

    Back to the top


    Powered by Savane 3.3