bugDenemo - Bugs: bug #36975, Right clicking to edit objects in...

 
 

bug #36975: Right clicking to edit objects in 0.9.5

Submitter:  John Beattie <jabeattie>
Submitted:  Fri 27 Jul 2012 10:24:06 AM UTC
   
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  None
Originator Name:  Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Sun 18 Nov 2012 04:48:22 PM UTC, comment #6: 

In git for quite a while now...

Richard Shann <rshann>
Group administrator
Sun 19 Aug 2012 08:54:19 AM UTC, comment #5: 

Yes, I think I fixed this already, though I notice that I have only the edit directives items there when directives are present, dropping the regular note-editing menu items. I have put these back, and am awaiting savannah to accept the push to git.

Richard Shann <rshann>
Group administrator
Sat 18 Aug 2012 07:04:48 PM UTC, comment #4: 

The problem that I am really seeing here is that right clicking note with an attached directive is not working.

With no directive, right click note brings up a dialog that allows you to change note, edit duration or toggle tie.

With a directive e.g. markup text or even something as simple as a staccato mark, all you get is a tiny box with a height about half the distance between lines on the staff. (an unpopulated dialog box ?)
You used to get the same dialog as above with extra options.

John Beattie <jabeattie>
Wed 15 Aug 2012 08:55:33 AM UTC, comment #3: 

1) yes, I think so. The idea of separate edit scripts may be redundant, since I in most cases the command scripts can be made self-editing. The ones that exist are very old.
2) Yes, RehearsalMark needs updating - it is broken now that we are displaying the print view using the evince widget. Before we had complete control over the display and you could actually drag a rehearsal mark to position it in the final print out. That is broken, and may not get revived. Meanwhile the script should be fixed, I am sure it could be self-editing too.
3) Unknown Tag should never be seen - in the early days there were no tags, but no script should generate such a thing.
4) If  you make the tag of the DenemoDirective the same as the command name then the command will be self-editing. Your command script should then check for the existence of the DenemoDirective with that tag and do the editing action you want otherwise do whatever it does at present.
5)This needs upgrading to self-edit too. In fact I think this is a one-liner using the scripting stuff that Nils created (e.g. Breath Mark).  I have been wanting for some time to make it offer Above and Below as options (perhaps, bold and italic...) but I need to get round to upgrading the option fetching command as it is horribly kludgy, and I've been reluctant to create more stuff that will need upgrading when that is done.

Richard Shann <rshann>
Group administrator
Tue 14 Aug 2012 02:47:51 PM UTC, comment #2: 

1) First of all, can I check that all the editscripts have been packaged up?
On 0.9.5 rc5 I have only 7 editscripts:
D.C.AlFine, LHFinger, Mute, RehearsalMark, StaffSize, StringNum, UnknownScoreTag
Most of these I have not tired.

2) I can confirm that right click on a Rehearsal Mark does call the correct editscript. However if you go to Advanced and the Delete Directive, it is not deleted.

3) I can confirm that UnknownScoreTag is NOT called when an unknown object is right clicked (one of mine that I had not yet loaded into this version. The Advanced directive edit is called.

4) I have copied and renamed UnknownScoreTag so that it is called for one of my scripts. Once I got the right type of d-DirectiveTextEdit- that seemed to work OK.

5) Need to have an edit script corresponding to Notes/Rests->Markings->Arbitrary Text. I've tried adding a Text.scm to editscript (another copy of UnknownScoreTag) but that makes no difference. All you get is a tiny grey rectangle (as before). You loose the other right click options too e.g. toggle tie.




John Beattie <jabeattie>
Fri 27 Jul 2012 01:34:25 PM UTC, comment #1: 

When the cursor is on a standalone Denemo Directive and you right click the EditObject command is invoked. What this does depends on the directives tag field.
If the tag is the name of a file actions/editscripts/<tag>.scm then the scheme in that file is executed.
If the tag is the name of a command then that command is invoked. Typically a script will look to see if the cursor is on an object that it created and do something useful in that case.
There is some further behavior depending on an override bit, which when set causes a text editor to be run.
Failing these, the low-level directive edit is launched (which should never be the case with user-facing objects, but we are still early days :)

Buttons created on the title bar are given a scheme script to run when clicked (I don't recall if there is some default behavior for the case where no script is attached). So what these buttons do is entirely controlled by the command that created them. You can see examples of this in the new commands in the InputMenu->Mouse menu.

The areas around the start of the staff in the display have been made sensitive (they are just areas in the display, not widgets) and can be used to run clef, keysig & timesig commands, as well as editing staff and voice directives when these are present. It was the latter that was misbehaving.

The script for Multi-measure rests may well need revising to do sensible things when the objects it creates are right-clickd. Whether a script picks up on a previous value set is again up to the script concerned. We need to move all scripts to adopt a consistent, useful and memorable pattern of behavior.

Richard Shann <rshann>
Group administrator
Fri 27 Jul 2012 10:24:06 AM UTC, original submission:  

In a response to bug 36928, Richard said that "the voice directives are not editable by clicking on the lower of the two
"tool" icons before the staff (which used to be the case)".
This may be a more general version of what Richard saw but I have been having problems with editing objects on both rc1 & rc2. I usually use right click but I also tried Edit->Edit Object with same effects.

I have the "Titles, Buttons, etc" view turned on.
In rc1 I noticed I was getting different results by different buttons. (some might have been created by some of my own scripts so that might be a difference but I think I was getting same mixture of results from both mime & standard scripts).
Sometimes right click went to edit directive dialog as expected. Other times it was as if it re-run the script as if it was the first time. Other times it re-run the script with previous value in as default.
In rc2, with the music I have been using for the recent tests I have several sets of Multi-Measure Rests which occur at starts of phrases which are marked by a bar number. I have a pair of scripts that turn bar numbering on and off. So I turn numbering on at end of previous bar and off at end of current bar. I do this after multi-measure rest have been set. This all works fine and has done for several releases of denemo. So imagine the screen: bar ending green line (number on), barline, MM rest, green line(number off), barline, grouped mm rest.
If I work my way along that line, right clicking each directive I get:
number on -nothing happens with right click
mm rest -nothing happens with right click
number off -nothing happens with right click
grouped mm rest - a single whole measure rest appears, bar goes red and existing grouped rest is pushed across to overlap one in next measure.(didn't want to edit that one anyway so undid the change)

Further on I have exactly the same thing except this time I want to change the mm rest; I want to increase its minimum-length. I can't edit the mm rest so I use Directives->Insert Lilypond. As with previous releases, this sometimes causes two directives to be merged into one and that was what happened here. Graphic for mm rest was replaced by another green line. (I think at this stage the bar went blue) This directive could be edited so I did. Tag field caused by insert directive looked like garbage so I changed Tag to MultiMeasureRest (a mistake), I also changed graphic to MultiMeasureRests, setup offsets, and moved the override for minium-length to prefix. I don't think the graphic changed immediately but it was ok next time music was loaded. When I noticed the mistake in the tag, I edited it again and put the s on the end. After doing that the directive could no longer be edited. NB the measure above is still blue (and found by check score but I'm not sure why -it is typeset the way I was expecting  it to be.)

Between this music & the more complicated piece I was working on when I started with rc1, I have seen unexpected results with editing directives at left of staffs, in Score->edit score directives, within staff and on buttons. The example about the tag name above suggests some of these changes might be deliberate, if so I'm not sure they should have been changed.

John Beattie <jabeattie>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rshann (Posted a comment)
  • -email is unavailable- added by jabeattie (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2012-11-18 rshann StatusConfirmed Fixed
        Open/ClosedOpen Closed
    2012-07-27 rshann StatusNone Confirmed

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code