bugXBoard - Bugs: bug #36228, reserved identifier violation

 
 

bug #36228: reserved identifier violation

Submitter:  Markus Elfring <elfring>
Submitted:  Tue 17 Apr 2012 06:30:16 PM UTC
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  Fixed
Assigned to:  None Open/Closed:  Closed
Release:  None
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       No canned response available

 

Sat 02 Jun 2012 06:31:41 PM UTC, comment #3: 

Thanks for your source code adjustments.

I hope that a tool like "Coccinelle" will become able to perform a corresponding semantic grep to find such update candidates.

Markus Elfring <elfring>
Mon 28 May 2012 08:06:29 PM UTC, comment #2: 

Changed this in master: renamed to XB. I also made the include guards names more consistent, e.g. XB_<filename>.

Same for variables I found with git grep " _[^(]".

Markus: is there an easy way to check the code for these compliance issues, e.g. something we can run over the code every now and then to find things like this?

Thanks for reporting this.

Arun Persaud <apersaud>
Project Administrator
Tue 17 Apr 2012 07:12:39 PM UTC, comment #1: 

There are more update candidates like "_ListGame" and "_OPT" besides the include guards.

Markus Elfring <elfring>
Tue 17 Apr 2012 06:30:16 PM UTC, original submission:  

I would like to point out that identifiers like "_BACKEND" and "[http://git.savannah.gnu.org/cgit/xboard.git/tree/xhistory.h?id=8e8f7200a0db9c816e5b508bc0cd377a393bda41#n23 _XHISTL_H" do not fit to the expected naming convention of the C language standard.
Would you like to adjust your selection for unique names?

Markus Elfring <elfring>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by apersaud (Posted a comment)
  • -email is unavailable- added by elfring (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

     

     

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2012-09-29 apersaud StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2012-05-28 apersaud StatusNone Ready For Test

    Back to the top


    Powered by Savane 3.9