bugGNU TeXmacs - Bugs: bug #36125, replace rsvg with rsvg-convert

 
 

You are not allowed to post comments on this tracker with your current authentification level.

bug #36125: replace rsvg with rsvg-convert

Submitted by:  Kamaraju Kusumanchi <kamaraju>
Submitted on:  Sat 07 Apr 2012 02:46:28 PM UTC  
 
Category: ConversionPriority: 7 - High
Item Group: CleanupStatus: Confirmed
Privacy: PublicAssigned to: Miguel de Benito <mdbenito>
Originator Name: Open/Closed: Open
Release: 1.0.7.15Release: None
Fixed Release: NoneFixed Release: 
Keywords: 

Thu 13 Sep 2012 07:06:52 AM UTC, comment #2:

I would not worry too much about backward compatibility: they say rsvg "has long been deprecated and replaced by rsvg-convert". So your patch should be fine even on rather old systems. Also rsvg(-convert) is not a hard dependency; if absent I guess texmacs falls back to longer paths suchs as svg->eps->png (if possible, of course).

However, while fixing this we should also address bug #30806, increasing the dpi with an extra -d option

"rsvg-convert -f png -d 300 -o " to from

300 dpi is maybe too high if this is only for on-screen, but on the other hand, as noted in the othe bug report, the required dpi depends on the final size of the image that convert doesn't know about.

Philippe Joyez <pjoyez>
Project Member
Sat 18 Aug 2012 08:27:50 AM UTC, comment #1:

I attach a patch which should work with rsvg-convert, but someone has to think how to handle both rsvg and rsvg-convert:

What about backwards compatibility? Does this command rsvg-convert exist in previous versions of the library and does it conflict in any way with the modern one?

I mean: if we must handle several versions, is it "safe" (to a certain degree) to assume that whenever rsvg is present in the path, then we have the old tool and whenever rsvg-convert then the new one?

In this case we need only check for these in the path. However, I don't think it's possible to overload converters in TeXmacs with the current infrastructure, so we cannot just add two converters for the same format with different (:require ) clauses (this feature would probably be suboptimal because most conditions are not mutually excluding, but anyway...).

Ideas?

(file #26379)

Miguel de Benito <mdbenito>
Project MemberIn charge of this item.
Sat 07 Apr 2012 02:46:28 PM UTC, original submission:

This bug is originally reported by Michael Biebl [1] . The rsvg tool has long been deprecated and is replaced by rsvg-convert. In a recent upstream commit, rsvg was removed from librsvg package [2].

The calls to rsvg-convert, rsvg are similar except that rsvg-convert requires -o option for the output file name, rsvg does not. For e.g.

> rsvg -w 64 -h 64 foo.svg > foo.png # works
> rsvg-convert -w 64 -h 64 foo.svg > foo.png # FAILS
> rsvg-convert -w 64 -h 64 -o foo.png foo.svg # works


The other parameters (-w,-h,-d,-p,-x,-y,-f) behave the same across the two.

Could you please update the rsvg calls to rsvg-convert?

[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=666482
[2] http://git.gnome.org/browse/librsvg/commit/?id=fd76212e2dc8e41b2c23d6e76c02cc7803da4a12

Kamaraju Kusumanchi <kamaraju>

 

Attached Files
file #26379:  bug_36125.patch added by mdbenito (577B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by pjoyez (Posted a comment)
  • -unavailable- added by mdbenito (Updated the item)
  • -unavailable- added by kamaraju (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 18 Aug 2012 08:27:50 AM UTCmdbenitoAttached File-=>Added bug_36125.patch, #26379
      CategoryNone=>Conversion
      Priority5 - Normal=>7 - High
      Item GroupNone=>Cleanup
      StatusNone=>Confirmed
      Assigned toNone=>mdbenito

    Back to the top


    Powered by Savane 3.1-cleanup