bugPSPP - Bugs: bug #35887, Sort functionality preallocates...

 
 

bug #35887: Sort functionality preallocates excessive memory

Submitter:  Ben Pfaff <blp>
Submitted:  Sun 18 Mar 2012 05:24:49 PM UTC
   
 
Category:  Other Severity:  5 - Average
Status:  Fixed Assigned to:  None
Open/Closed:  Closed Release:  None
Effort:  0.00
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 19 Mar 2012 04:43:13 AM UTC, comment #1: 


> The sort code should allocate memory as actually needed, not all in advance.


I pushed commit c13310dc3f (sort: Allocate space for sort buffers on demand, not in advance.) to fix this.

Ben Pfaff <blp>
Group administrator
Sun 18 Mar 2012 05:24:49 PM UTC, original submission:  

John Darrington writes:

> The partcular problem I encountered stems from the fact, that
> for every category, I'm calling sort_create_writer, which in
> turn allocates space for a large number of cases - even if they
> are never used.  I think I can solve that problem by sorting
> the cases before categorising.  But I'm wondering if similar
> situations will arise where such an optimisation cannot be
> done.


This is excessive.  The sort code should allocate memory as actually needed, not all in advance.

Ben Pfaff <blp>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by blp (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2012-03-19 blp StatusNone Fixed
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code