bugPSPP - Bugs: bug #35825, incomplete ENCODING subcommand on...

 
 

bug #35825: incomplete ENCODING subcommand on PRINT

Submitter:  None
Submitted:  Tue 13 Mar 2012 12:03:43 PM UTC
   
 
Category:  System/Portable File I/O Severity:  5 - Average
Status:  Fixed Assigned to:  None
Open/Closed:  Closed Release:  Before 0.8.0
Effort:  0.00
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Tue 25 Dec 2012 01:15:54 AM UTC, comment #12: 

I pushed a fix.

Ben Pfaff <blp>
Group administrator
Mon 24 Dec 2012 08:08:26 AM UTC, comment #11: 

I've made significant progress on encoding support for PRINT.  I'm just debugging one remaining bug.

Ben Pfaff <blp>
Group administrator
Tue 27 Nov 2012 06:38:54 AM UTC, comment #10: 

I thought that I hadn't fixed this, but in fact ENCODING now works OK on DATA LIST, as far as I can tell.  It's the PRINT command where ENCODING isn't fully implemented.

I've changed the summary to indicate that.

Ben Pfaff <blp>
Group administrator
Sat 13 Oct 2012 10:02:58 PM UTC, comment #9: 


>Has this one now been fixed?


No, I haven't taken care of it yet.

Ben Pfaff <blp>
Group administrator
Fri 12 Oct 2012 09:57:34 AM UTC, comment #8: 

Has this one now  been fixed?

John Darrington <jmd>
Group administrator
Mon 19 Mar 2012 08:25:39 AM UTC, comment #7: 

Great i'll give it a try when you're ready.

Bernd Jänichen <bjaenichen>
Mon 19 Mar 2012 04:46:11 AM UTC, comment #6: 

The "lexer" branch at git://benpfaff.org/pspp fixes the problem, but it needs some polishing before it is ready for master.

Ben Pfaff <blp>
Group administrator
Sat 17 Mar 2012 07:03:38 PM UTC, comment #5: 

Ah, it seems that the work on encodings is simply incomplete.  I have a local branch that has a start.  I'll try to get it up to speed.

Ben Pfaff <blp>
Group administrator
Sat 17 Mar 2012 06:24:33 PM UTC, comment #4: 

Bernd, thank you for the explanation.  I see the problem, too.  I'll try to solve it.

Ben Pfaff <blp>
Group administrator
Wed 14 Mar 2012 01:00:37 PM UTC, comment #3: 

Ok, i'll give it a try with the master.

The encoding param in "DATA LIST FREE TABLE FILE ... ENCODING" command isn't recognized at all.

For example, if i load a datafile encoded in ISO-8859-15 the characters 'äöüß' are broken in the resulting .sav file when opening it in SPSS on a windows machine that has that codepage enabled.

I'll attach example files to let you reproduce that problem:

pspp --syntax-encoding=ISO-8859-15 --no-output pspp_iso_deffile


Thx,
Bernd

Bernd Jänichen <bjaenichen>
Wed 14 Mar 2012 05:21:46 AM UTC, comment #2: 


> Creation of portable files ends up in an infinite loop.


This bug was already fixed back on February 6.  The samples you supplied work fine with PSPP from "master".

I've changed the title of the bug report to reflect the other bug you reported.  Can you describe the bug that you see there?

Thanks,

Ben.

Ben Pfaff <blp>
Group administrator
Tue 13 Mar 2012 12:10:23 PM UTC, comment #1: 

Sorry, i didn't add my mailaddress when creating this issue it's bernd.jaenichen@questback.de.

Bernd Jänichen <bjaenichen>
Tue 13 Mar 2012 12:03:43 PM UTC, original submission:  

Creation of portable files ends up in an infinite loop.

How to reproduce (Needed input files are attached):

pspp --syntax-encoding=UTF-8 --no-output pspp_utf8_deffile

I've attached a patch fixing this issue maybe it helps to identify the problem.

The patch also contains a fix for Input/Output encoding of data-files loaded by "DATA LIST FREE TABLE FILE ... ENCODING" command.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #25361:  pspp_iso_deffile added by bjaenichen (4KiB - application/octet-stream)
file #25362:  pspp_iso_datafile added by bjaenichen (799B - application/octet-stream)
file #25351:  pspp_patch_utf8.diff added by None (3KiB - text/x-diff)
file #25352:  pspp_utf8_datafile added by None (1KiB - application/octet-stream)
file #25353:  pspp_utf8_deffile added by None (3KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jmd (Posted a comment)
  • -email is unavailable- added by bjaenichen (Posted a comment)
  • -email is unavailable- added by blp (Posted a comment)
  • -email is unavailable- added by bjaenichen (i created this issue)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 14 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2012-12-25 blp StatusConfirmed Fixed
        Open/ClosedOpen Closed
    2012-11-27 blp Summarywrong encoding with DATA LIST FREE ENCODING=... incomplete ENCODING subcommand on PRINT
    2012-11-26 blp ReleaseNone Before 0.8.0
    2012-03-17 blp StatusNone Confirmed
    2012-03-14 bjaenichen Attached File- Added pspp_iso_deffile, #25361
        Attached File- Added pspp_iso_datafile, #25362
    2012-03-14 blp CategoryOutput Driver System/Portable File I/O
        SummaryInfinite loop in por-file-writer.c wrong encoding with DATA LIST FREE ENCODING=...
    2012-03-13 bjaenichen Carbon-CopyRemoved 87494 -
    2012-03-13 bjaenichen Carbon-Copy- Added bjaenichen
    2012-03-13 None Attached File- Added pspp_patch_utf8.diff, #25351
        Attached File- Added pspp_utf8_datafile, #25352
        Attached File- Added pspp_utf8_deffile, #25353

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code