bugXBoard - Bugs: bug #34991, Load engine doesn't work in...

 
 

bug #34991: Load engine doesn't work in localized xboard

Submitter:  Byrial Jensen <bjensen>
Submitted:  Mon 05 Dec 2011 01:20:20 PM UTC
 
Category:  XBoard (X11) Severity:  3 - Normal
Item Group:  Translation Status:  Fixed
Assigned to:  apersaud Open/Closed:  Closed
Release:  None
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       No canned response available

 

( Jump to the original submission )

Fri 16 Dec 2011 11:53:31 AM UTC, comment #6: 

Status of this bug:

It seems to be all fixed from a functional point of view:
1) The browse buttons work for Load engine and elsewhere
2) The Select engine combobox doesn't translate engine name or the empty string. This is also fixed in Match options.

Where remains some small cosmetic problems:
1) The browse buttons with translated title for some unknown to me reason is a little higher than before and may overlap a little with the control in the line below.
2) The attempt to make all controls have the same width in popop windows doesn't take into account that the width of browse buttons now depend on the translation.

You can see both of these cosmetic problems for instance in
the engine options window for Fairy-Max.

Byrial Jensen <bjensen>
Project Member
Tue 13 Dec 2011 01:20:05 PM UTC, comment #5: 

You cannot just remove gettext calls from the combo code.

They are also used for combo boxes where translation is needed (search mode in Load options, the sound names in sounds options, load as first or second engine in Load engine)

I see 3 ways to fix this:
1) Create arrays of the translated messages for these combo boxes in advance,
2) Have a flag in struct Option to indicate if gettext should be called (or reuse one of the variables otherwise not used for ComboBox options for this)
3) Have two Combobox values in enum Control: ComboBox and ComboBoxWithNoTranslation

Byrial Jensen <bjensen>
Project Member
Tue 13 Dec 2011 02:50:09 AM UTC, comment #4: 

This should be fixed now. I removed the gettext calls from ComboSelect and CreateComboPopup.

git commit: 89c6ae1124d9eddb9fca185734ad3b6f8cf4ff54

Arun Persaud <apersaud>
Project Administrator
Sun 11 Dec 2011 12:47:34 AM UTC, comment #3: 

I just tried to load an engine with the nickname "Edit". The nickname became translated to Danish in the engine list, so it seems to me that all entries in the list (both the empty string and reel nicknames are wrongly translated.

Byrial Jensen <bjensen>
Project Member
Sun 11 Dec 2011 12:25:44 AM UTC, comment #2: 

Yes, all browse buttons (in the Load Engine window and else where) seem now to work and to have a size fitting for the text.

The Combo box still contains the po file header as the the first item.

Byrial Jensen <bjensen>
Project Member
Sun 11 Dec 2011 12:13:19 AM UTC, comment #1: 

Can you try the latest git version?

  • added error message to translation (pot not yet updated)
  • browse button should be fixed
  • clicking on the browse button should work for translations

Let me know if it works for you

Arun Persaud <apersaud>
Project Administrator
Mon 05 Dec 2011 01:20:20 PM UTC, original submission:  

Version 4.6.0.20111101

The Load engine function doesn't work with xboard in Danish.

The browse buttons (which btw are too small as reported earlier) doesn't work. Nothing at all happens when they are clicked.

The "Select engine from list:" combo box has the header from the da.po file as an option instead of an empty line. The header of a po file have the syntax of a translation of an empty string, so the _() function must have been called with an empty string as argument.

If the po file header is selected as an engine, xboard quits with the error message "xboard: No value provided for argument -fcp" which btw is not translated.

The error message is about -fcp even if I try to select it as second engine.

Byrial Jensen <bjensen>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by apersaud (Posted a comment)
  • -email is unavailable- added by bjensen (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

     

     

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2012-09-29 apersaud StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2011-12-11 apersaud Item GroupNone Translation
        StatusNone Ready For Test
        Assigned toNone apersaud

    Back to the top


    Powered by Savane 3.9