bugDenemo - Bugs: bug #33190, Tempo script

 
 

bug #33190: Tempo script

Submitter:  Richard Shann <rshann>
Submitted:  Sun 01 May 2011 05:23:36 PM UTC
   
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  None
Originator Name:  Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Tue 07 Jun 2011 01:35:22 PM UTC, comment #3: 

The self-editing is now fixed in git. I notice that Tempo goes through a preliminary menu on self-editing, allowing Delete, while BeatChange does not.

Also with this fix it is now revealed that many other comands like BreathMark do not respond helpfully when executed on themselves - they could offer an explanation of what the object was doing, and offer to delete it at least.

I have spent no time studying git either, but for your purposes after doing a git clone you will find it is remarkably painless, you just git commit your new version and git push to send it to savannah. You git add a new file.


Richard Shann <rshann>
Group administrator
Sat 04 Jun 2011 08:55:06 PM UTC, comment #2: 

I've tinkered with the Tempo script, and separated out the BeatChange to a separate command with a separate directive tag.  I've also changed the Tempo tag to simply 'Tempo' rather than 'TempoMark'.  However, right-clicking a tempo directive now brings up a rather useless GetOption with 4 non-working options.  Executing the Tempo command when the cursor is on the directive does indeed bring up the correct editor built-in to the command itself.  So something isn't quite right about the right-clicking, since as you describe it it should invoke the command itself.

Hate to admit it but I haven't taken the time to get used to git.  So I'm just posting the updated scripts here.  They could still be improved regarding the 'AI' guessing correct values for the midi BPM.  However, is there a way to GetCurrentBPM or something similar, which would return the current midi bpm in quarter-notes per minute?
-Dan W.

(file #23500, file #23501)

Anonymous
Sun 01 May 2011 09:34:33 PM UTC, comment #1: 

I'm not surprised to hear of bugs like these in the scripts.  I thought about making the beat change a separate script but didn't want too many different commands with separate shortcuts--invoking beat change from the tempo script sounds like a good solution.  At the moment I'm too busy to do much of anything with Denemo, so anyone who sees the solution is welcome to go ahead with it.  If this is still around when I get some time I'll address it then.
-Dan W.

Anonymous
Sun 01 May 2011 05:23:36 PM UTC, original submission:  

I noticed that the tempo script does not self-edit, in the sense that right clicking on a directive created by it does not run the script. This is because the tag used is not the name of the command. Since this script is working as its own editor, this could be fixed by changing the tag to "Tempo" or the name of the command to "TempoMark"
This then raises another issue, and a bug. This command can also create "BeatChange" directives - really that could be a separate command invoked by this one. As it is these miss-behave if you invoke the Tempo command with the cursor on the BeatChange directive. Instead of editing the BeatChange it spews out several directives. So really a d-BeatChange that did that part (and self edited) would be better, it could still be invoked from the Tempo option list. It would have to be a separate command in order for right clicking on a BeatChange directive would invoke it, though, rather than invoking the advanced editor.

Richard Shann <rshann>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #23500:  BeatChange added by None (4KiB - application/octet-stream)
file #23501:  Tempo added by None (8KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rshann (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2011-06-07 rshann StatusNone Fixed
        Open/ClosedOpen Closed
    2011-06-04 None Attached File- Added BeatChange, #23500
        Attached File- Added Tempo, #23501

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code