bugGNU TeXmacs - Bugs: bug #32953, with invalid mode crashes

 
 

You are not allowed to post comments on this tracker with your current authentification level.

bug #32953: with invalid mode crashes

Submitted by:  Sam Liddicott <samjam>
Submitted on:  Wed 30 Mar 2011 02:01:07 PM UTC  
 
Category: EditorPriority: 5 - Normal
Item Group: ErrorStatus: Fixed
Privacy: PublicAssigned to: Joris van der Hoeven <vdhoeven>
Originator Name: Open/Closed: Closed
Release: Release: None
Fixed Release: NoneFixed Release: 
Keywords: error handling

Fri 29 Nov 2013 05:12:08 PM UTC, comment #4:

Fixed in revision 7957.

I fixed this particular bug, but we do not have a general policy yet to avoid similar bugs. I am in the process of avoiding blunt termination, but we lack consistent checking of and recovery from invalid situations. Anyway, manual correction of a few most annoying situations should already be quite helpful.

Joris van der Hoeven <vdhoeven>
Project AdministratorIn charge of this item.
Tue 13 Mar 2012 10:06:09 AM UTC, comment #3:

Maybe invalid mode values should be rendered as source?

Sam Liddicott <samjam>
Project Member
Mon 05 Mar 2012 05:46:28 PM UTC, comment #2:

During last week's Workshop, the issue of error handling was discussed. The problem was certainly acknowledged, but the task is far from trivial. This problem and all those related could perhaps be closed ore somehow grouped.

A very nasty hack is to set DEBUG_ASSERT to 0 in config.h in the root src directory, then comment out the lines at the end of the definition of tm_failure() and the exit(1) at the beginning. This will undoubtedly have tons of undesirable side effects, so it's far from a solution.

In this particular instance, the side effects include the creation of a crash report for each key stroke while in the invalid mode.

Another, more local hack is to comment out the FAILED("invalid mode") in edit_interface.cpp line 35.

Miguel de Benito <mdbenito>
Project Member
Thu 14 Jul 2011 08:38:36 PM UTC, comment #1:

As can be easily seen this is the result of a failed assertion inside MODE_LANGUAGE in file edit_interface.cpp, line 35.

Since it seems policy everywhere in the code to exit the program whenever such a syntax error is found, this cannot be fixed without some input from Joris. Why is this done so? How could we safely recover from such errors in a consistent way? Is it already being done somewhere else?

Miguel de Benito <mdbenito>
Project Member
Wed 30 Mar 2011 02:01:07 PM UTC, original submission:

Setting an invalid mode causes texmacs to terminate (grrr)

<with|mode|typo|something>

Sam Liddicott <samjam>
Project Member

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by vdhoeven (Updated the item)
  • -unavailable- added by mdbenito (Posted a comment)
  • -unavailable- added by samjam (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 11 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 29 Nov 2013 05:12:08 PM UTCvdhoevenStatusPostponed=>Fixed
      Assigned tomdbenito=>vdhoeven
      Open/ClosedOpen=>Closed
    Thu 08 Mar 2012 01:44:57 PM UTCvdhoevenOpen/ClosedAccepted=>Open
    Mon 05 Mar 2012 05:46:28 PM UTCmdbenitoStatusConfirmed=>Postponed
      Open/ClosedOpen=>Accepted
      Keywords=>error handling
    Thu 14 Jul 2011 08:38:36 PM UTCmdbenitoCategoryNone=>Editor
      Item GroupNone=>Error
      StatusNone=>Confirmed
      Assigned toNone=>mdbenito

    Back to the top


    Powered by Savane 3.1-cleanup