bugDenemo - Bugs: bug #31901, d-MoveToBeginning returns #f but...

 
 

bug #31901: d-MoveToBeginning returns #f but should return #t.

Submitted by:  Nils Gey <steele>
Submitted on:  Fri 17 Dec 2010 12:40:33 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Duplicate
Privacy: PublicAssigned to: None
Open/Closed: Open

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 07 Apr 2011 09:23:50 AM UTC, comment #5:

this is now under another bug report, and I think is fixed anyway.

Richard Shann <rshann>
Project Administrator
Sat 18 Dec 2010 10:13:41 AM UTC, comment #4:

In my eyes "success" is the correct indicator if a return value should be #t or #f. I think Denemo follows this concept already pretty well.

If I take d-NextObject the command (name) indicates that success means if I reached the "Next" object. Now "next" makes it clear that there must be movement involved, there is no next if the cursor does not move. This is relative movement. You test if there is a difference in the cursor position and return #f

But in case of d-MoveToBeginning the destination is an absolute point. We have absolute movement. The difference of the cursor position does not matter here. Important is that the cursor is where it should be, in this case return #t.
This is also #t if the cursor was already in the Beginning. Moving to an absolute point takes no interest where you came from.

P.S. we should check if d-MoveToEnd (and the selection variants of both commands) return what we want.

Nils Gey <steele>
Fri 17 Dec 2010 01:01:21 PM UTC, comment #3:

So we have to decide whether to reduce the information the user gets or not because we think the user will expect the return value should always reflect "success".
That is, if it returns #t when the cursor has moved and #f if it does not, then we are telling the user something useful, if it always returns #t we are not, but we might be meeting an expectation of his.

Richard Shann <rshann>
Project Administrator
Fri 17 Dec 2010 09:57:16 AM UTC, comment #2:

But if you are already in the beginning position and invoke the command you expect it to return #t also.

Anonymous
Fri 17 Dec 2010 08:09:39 AM UTC, comment #1:

It could be defined to return #f if the cursor did not move.
I think other commands that move the cursor may do that.

Richard Shann <rshann>
Project Administrator
Fri 17 Dec 2010 12:40:33 AM UTC, original submission:

d-MoveToBeginning returns #f but should return #t.

I don't know any situation where MoveToBeginning could possibly return #f. There is always a staff.

Nils Gey <steele>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rshann (Posted a comment)
  • -unavailable- added by steele (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follows 1 latest change.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 07 Apr 2011 09:23:50 AM UTCrshannStatusNone=>Duplicate

    Back to the top


    Powered by Savane 3.1-cleanup