bugmake - Bugs: bug #30662, Windows build fails due to missing...

 
 

bug #30662: Windows build fails due to missing -I option for subproc/misc

Submitter:  None
Submitted:  Thu 05 Aug 2010 07:07:36 PM UTC
   
 
Severity:  3 - Normal Item Group:  Build/Install
Status:  Fixed Privacy:  Public
Assigned to:  eliz Open/Closed:  Closed
Component Version:  3.82 Operating System:  MS Windows
Fixed Release:  4.0 Triage Status:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Sun 29 Aug 2010 05:10:33 AM UTC, comment #5: 

I've modified the options for the files that appeared to have CRLF characters in them, but did not have -kb set, to use -kb so they are treated as binary.

Please let me know if I've missed any or this causes any issues.

Paul D. Smith <psmith>
Group administrator
Wed 18 Aug 2010 12:28:15 AM UTC, comment #4: 

Hi Eli,

dosbuild.bat and prepare_w32.bat are fine (I haven't mentioned those as wrong), which explains the problem nicely. So as you say, the solution would be to re-upload the wrong files with -kb option and CRLF EOLs.

[ Doing that on checkout might not be without problems on Windows, plus AFACS '-kb' option is not available at checkout time, at least on my version of CVS. It's also missing from the CVS checkout example on the source browse page. ]

Viktor

Anonymous
Mon 16 Aug 2010 07:15:23 PM UTC, comment #3: 

All the files you mentioned have DOS CRLF line endings in the CVS repository.  It sounds like your CVS client converts line endings.  Two of the files you mentioned -- dosbuild.bat and prepare_w32.bat -- were committed as binary files, so their line endings are not converted and stay CRLF.

On Windows, I always invoke co and up commands with the -kb switch, to avoid this problem with CVS clients.

Eli Zaretskii <eliz>
Group Member
Sun 15 Aug 2010 09:53:20 PM UTC, comment #2: 

Thanks a lot for the fix.

I used CVS (version 1.11.15) on Windows to download the sources and not all, but some .bat and few other Windows specific files have CRCRLF line endings: build_w32.bat, configure.bat, subproc.bat, make_msvc_net2003.sln, make_msvc_net2003.vcproj, w32\subproc\build.bat.

This suggests it has something to do with how the files were uploaded or configured on CVS.

Viktor

Anonymous
Sat 07 Aug 2010 08:57:45 AM UTC, comment #1: 

Thanks for the report.

I fixed this by making all cl.exe command lines use the same /I switches.

I see no CRCRLF line endings in build.bat, only the normal CRLF.  So perhaps this was caused by some utility you used to unpack the distribution.

Eli Zaretskii <eliz>
Group Member
Thu 05 Aug 2010 07:07:36 PM UTC, original submission:  

Hi,

w32/subproc/build.bat missed '-I ../..' when compiling misc.c with cl.exe (both release and debug modes), which makes Windows builds fail.

Also build.bat contained CRCRLF EOLs, that's why diff dumped the whole file as difference.

Pls find patch attached.

Viktor Szakats

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #21152:  make_win32_inc.dif added by None (5KiB - video/x-dv)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by psmith (Posted a comment)
  • -email is unavailable- added by eliz (Posted a comment)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-08-29 psmith Component Version4.0 3.82
        Fixed ReleaseNone 4.0
    2010-08-07 eliz StatusNone Fixed
        Assigned toNone eliz
        Open/ClosedOpen Closed
    2010-08-05 None Attached File- Added make_win32_inc.dif, #21152

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code