bugmake - Bugs: bug #30653, intermediate files incorrectly...

 
 

bug #30653: intermediate files incorrectly pruned in parallel builds

Submitter:  Jeremy Devenport <jeremyd>
Submitted:  Thu 05 Aug 2010 01:24:56 AM UTC
   
 
Severity:  3 - Normal Item Group:  Bug
Status:  Fixed Privacy:  Public
Assigned to:  psmith Open/Closed:  Closed
Component Version:  3.82 Operating System:  Any
Fixed Release:  4.0 Triage Status:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 06 Jan 2014 08:10:33 PM UTC, comment #5: 

I'm personally not invested either way since this particular bug fix is short enough to not be subject to copyright anyway (it falls under fair use exceptions), so you could just create your own patch file with that change in it (the one additional line to remake.c) without asking permission at all and that's perfectly fine.

However just to note, a patch is clearly a derived work of the GNU make codebase and as such (if it was subject to copyright requirements, and barring other agreements such as copyright assignment etc.) it would be jointly copyright between the FSF and Jeremy D. and the only way the license could be modified would be with the unanimous agreement of both parties.

The applicable license, unless/until a change was agreed, would be the one under which the code was licensed when Jeremy D. created his patch.  Assuming he was working with GNU make 3.82, the license is GPLv3.

It's not possible to backport changes from newer versions of GNU make, with a newer license, to older versions of GNU make, with an older license, then release the whole thing under the older license.  That's not how it works...

Paul D. Smith <psmith>
Group administrator
Mon 06 Jan 2014 07:48:43 PM UTC, comment #4: 

The version committed appears to be my patch (with a cleanup to the code comment and the test case condensed to use fewer lines). I'm fine with making my patch available as GPL2+.

Jeremy Devenport <jeremyd>
Sat 04 Jan 2014 07:05:54 PM UTC, comment #3: 

Jeremy and Kamil,

Can you please comment as to the licensing requirements of your patches?  Are they available as GPL2+ or GPL3? (ie, will you allow me to apply them to make 3.8.1 as GPL2+).

If you specified in the patch, I apologize as I do not want to look at them prior to knowing that they are not GPL3+.

Which version was actually committed?

Jeremy Huddleston Sequoia <jeremyhu>
Mon 10 Sep 2012 02:36:58 AM UTC, comment #2: 

Fix applied.  Thank you both for the useful test cases and debugging work.

Paul D. Smith <psmith>
Group administrator
Thu 05 Aug 2010 08:47:09 AM UTC, comment #1: 

I have also encountered this bug and debugged it a little. I posted my comments to the bug-make list:

http://lists.gnu.org/archive/html/bug-make/2010-07/msg00155.html

Kamil Mierzejewski <kmierzejewski>
Thu 05 Aug 2010 01:24:56 AM UTC, original submission:  

make 3.82 sometimes fails to make intermediate (or secondary) files during parallel builds. I see that there are a couple bug reports with similar titles but this particular bug seems to have been introduced in 3.82 (and is still present in CVS).

I'm attaching a patch that adds a test that demonstrates the bug along with a fix that seems to work. I'm not very familiar with the code so I'm not sure that my fix doesn't break something else.

Jeremy Devenport <jeremyd>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #21146:  parallel_intermediates.patch added by kmierzejewski (674B - application/octet-stream - I also encountered this bug. I came up with an alternative solution. I'm not sure if it breaks anything as well.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jeremyhu (Posted a comment)
  • -email is unavailable- added by psmith (Posted a comment)
  • -email is unavailable- added by kmierzejewski (Updated the item)
  • -email is unavailable- added by jeremyd (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2012-09-10 psmith StatusNone Fixed
        Assigned toNone psmith
        Open/ClosedOpen Closed
        Component Version4.0 3.82
        Fixed ReleaseNone 4.0
    2010-08-05 kmierzejewski Attached File- Added parallel_intermediates.patch, #21146
    2010-08-05 jeremyd Attached File- Added make-intermediate-parallel-bug.patch, #21144

    Back to the top

    Powered by Savane 3.13-cf05.
    Corresponding source code