bugXBoard - Bugs: bug #29962, configure.ac has unnecessary...

 
 

bug #29962: configure.ac has unnecessary bashisms

Submitter:  Clint Adams <clint>
Submitted:  Wed 26 May 2010 01:23:57 AM UTC
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  Fixed
Assigned to:  apersaud Open/Closed:  Closed
Release:  None
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       No canned response available

 

Sat 05 Jun 2010 08:12:13 PM UTC, comment #3: 

Applied your patch. Thanks for the contribution :)

Arun Persaud <apersaud>
Project Administrator
Wed 26 May 2010 02:47:09 PM UTC, comment #2: 

Oops, I'm wrong, "test" is built in to bash, and GNU /usr/bin/test does not recognize ==.  I thought I had checked that before posting, but evidently I checked it in an invalid way.

Tim Mann <mann>
Project Administrator
Wed 26 May 2010 07:31:01 AM UTC, comment #1: 

Technically that might be a gnuism, but it isn't a bashism, because "test" in that context invokes /usr/bin/test as a separate program.  "test" isn't built in to bash.

However, I'm just quibbling here. Your change is good. Thanks.

Tim Mann <mann>
Project Administrator
Wed 26 May 2010 01:23:57 AM UTC, original submission:  

The portable binary equality operator to test is "=", not "==".  The former works portably on more shells.

Clint Adams <clint>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by apersaud (Posted a comment)
  • -email is unavailable- added by mann (Posted a comment)
  • -email is unavailable- added by clint (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

     

     

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-06-05 apersaud StatusNone Fixed
        Assigned toNone apersaud
        Open/ClosedOpen Closed
    2010-05-26 clint Attached File- Added 0001-Remove-unnecessary-double-equals-from-configure.ac.patch, #20620

    Back to the top


    Powered by Savane 3.9