bugPSPP - Bugs: bug #29659, Clicking on upper-left corner of...

 
 

bug #29659: Clicking on upper-left corner of data sheet causes crash

Submitter:  Ben Pfaff <blp>
Submitted:  Sat 24 Apr 2010 06:53:20 PM UTC
   
 
Category:  Graphical User Interface Severity:  5 - Average
Status:  None Assigned to:  None
Open/Closed:  Closed Release:  None
Effort:  0.00
* Mandatory Fields

Add a New Comment Rich Markup
   

Sat 08 May 2010 06:00:19 PM UTC, comment #2: 

Thanks for the patch.  It fixes the problem for me, too, so I pushed it out and I'm closing the bug.

Ben Pfaff <blp>
Group administrator
Sat 08 May 2010 01:31:14 AM UTC, comment #1: 

I think the problem is that psppire_sheet_select_range (lib/gtk-contrib/psppire-sheet.c:2710) doesn't support its second argument to be NULL, since it dereferences this argument.

But, on the same file, line 3027 we have:
psppire_sheet_select_range (sheet, NULL);

This only happens if both row and column are equal -1 which only happens if you click on the marked area.

Since click on this cell should do nothing, and there is already code to avoid problems with this click inside the if, I guess the best solution whould be simple remove line 3027.

The attached patch should do it, and also fix a strange line break on line 3026

(file #20478)

Michel Boaventura <michelboaventura>
Group Member
Sat 24 Apr 2010 06:53:20 PM UTC, original submission:  

From original email archived at http://permalink.gmane.org/gmane.comp.statistics.pspp.user/806:


From: Matej Kovacic <matej.kovacic@owca.info>
...
First is - if I click to a area marked in "click-error.png" (in Ubuntu
Karmic build), PSPP just closes (crashes?), without any warning or question.


Image attached.

Ben Pfaff <blp>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #20314:  click-error.png added by blp (28KiB - image/png)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by michelboaventura (Updated the item)
  • -email is unavailable- added by blp (Submitted the item)
  • -email is unavailable- added by blp
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-05-08 blp Open/ClosedOpen Closed
    2010-05-08 michelboaventura Attached File- Added fix_corner_click.patch, #20478
    2010-04-24 blp Attached File- Added click-error.png, #20314
        Carbon-Copy- Added matej kovacic <matej.kovacic@owca.info>

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code