bugDenemo - Bugs: bug #27931, Clef chooser lacks bass?

 
 

bug #27931: Clef chooser lacks bass?

Submitter:  None
Submitted:  Wed 04 Nov 2009 03:47:10 AM UTC
   
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  None
Originator Name:  Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Fri 22 Jan 2010 06:05:53 PM UTC, comment #5: 

thanks, I nearly missed this because the status was still "fixed"
now in git

Richard Shann <rshann>
Group administrator
Wed 13 Jan 2010 03:44:25 AM UTC, comment #4: 

The script I just sent didn't delete the drum clef middlec position directive.  This one does.  I hope it's sound.

-Dan

;;;;ClefChooser
(let ((choice "Bass"))
  (set! choice (d-GetOption  (string-append "Treble" stop "Bass" stop "Alto" stop "Tenor" stop "Octava bassa" stop "Soprano" stop  "Drum" stop)))
    (cond
     ((boolean? choice) () )
     ((equal? choice "Drum")
      (begin
;(d-CursorRight)
(d-InitialClef "Bass")
(d-DirectivePut-clef-override "DrumClef" DENEMO_OVERRIDE_LILYPOND)
(d-DirectivePut-clef-postfix "DrumClef" "\\clef percussion\n ")
(d-DirectivePut-clef-graphic "DrumClef" "DrumClef")
(d-StaffProperties "midi_channel=9")
(d-PushPosition)
(d-GoToBeginning)
(d-DirectivePut-standalone-postfix "MiddleCPosition" "\\set Staff.middleCPosition = #6")
(d-PopPosition)
;; (d-DirectivePut-voice-postfix "DrumClef"  "\\drummode ")
;; (d-DirectivePut-voice-override "DrumClef" DENEMO_OVERRIDE_LILYPOND)
;; (d-DirectivePut-staff-postfix "DrumClef" "<< { \\new DrumStaff\n")
;; (d-DirectivePut-staff-override "DrumClef" DENEMO_OVERRIDE_LILYPOND)
))
     (#t
      (if (d-CursorLeft)
  (begin
    (d-CursorRight)
    (d-InsertClef choice))
  (begin
(if  (equal? (d-DirectiveGetTag-clef ) "DrumClef" )
(begin (d-DirectiveDelete-clef "DrumClef")
     (if (equal? (d-DirectiveGetTag-standalone ) "MiddleCPosition") (d-DeleteObject) )
             )
)
    (d-InitialClef choice)  
    )))))
(d-RefreshDisplay)

(file #19480)

Anonymous
Wed 13 Jan 2010 03:30:29 AM UTC, comment #3: 

The attached script fixes a few problems with ClefChooser.
First it puts the Bass clef as the second choice, whereas before it was absent.
It eliminates the unnecessary "Operation Cancelled" dialog box.
It fixes a slight problem with the drum clef.  Suppose you had mistakenly entered a drum clef as initial and then tried to put the initial clef to treble.  The drum clef directive would still be there, and you'd see the same drum clef there.  It wouldn't go away.  This fixes that by deleting the directive when it finds it.
Hope it helps.
-Dan W.
Here it is pasted:


;;;;ClefChooser
(let ((choice "Bass"))
  (set! choice (d-GetOption  (string-append "Treble" stop "Bass" stop "Alto" stop "Tenor" stop "Octava bassa" stop "Soprano" stop  "Drum" stop)))
    (cond
     ((boolean? choice) () )
     ((equal? choice "Drum")
      (begin
;(d-CursorRight)
(d-InitialClef "Bass")
(d-DirectivePut-clef-override "DrumClef" DENEMO_OVERRIDE_LILYPOND)
(d-DirectivePut-clef-postfix "DrumClef" "\\clef percussion\n ")
(d-DirectivePut-clef-graphic "DrumClef" "DrumClef")
(d-StaffProperties "midi_channel=9")
(d-PushPosition)
(d-GoToBeginning)
(d-DirectivePut-standalone-postfix "MiddleCPosition" "\\set Staff.middleCPosition = #6")
(d-PopPosition)
;; (d-DirectivePut-voice-postfix "DrumClef"  "\\drummode ")
;; (d-DirectivePut-voice-override "DrumClef" DENEMO_OVERRIDE_LILYPOND)
;; (d-DirectivePut-staff-postfix "DrumClef" "<< { \\new DrumStaff\n")
;; (d-DirectivePut-staff-override "DrumClef" DENEMO_OVERRIDE_LILYPOND)
))
     (#t
      (if (d-CursorLeft)
  (begin
    (d-CursorRight)
    (d-InsertClef choice))
  (begin
(if  (equal? (d-DirectiveGetTag-clef ) "DrumClef" ) (d-DirectiveDelete-clef "DrumClef") )
    (d-InitialClef choice)  
    )))))
(d-RefreshDisplay)

(file #19479)

Anonymous
Tue 12 Jan 2010 08:08:35 PM UTC, comment #2: 

It appears this problem still exists.  I.e., the clef chooser still does not have the bass clef as an option.
  Also, when you hit cancel, why does it need to tell you with a dialog "Operation Cancelled"?

Anonymous
Sun 08 Nov 2009 10:12:03 AM UTC, comment #1: 

in git.

Richard Shann <rshann>
Group administrator
Wed 04 Nov 2009 03:47:10 AM UTC, original submission:  

It appears to be lacking in the 0.8.10 version on Windows.
Looking at the script, it seems like it's set as the default but not added to the list of options.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #19480:  ClefChooser2 added by None (2KiB - application/octet-stream)
file #19479:  ClefChooser2 added by None (2KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by steele (Updated the item)
  • -email is unavailable- added by rshann (Posted a comment)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-12-04 steele Open/ClosedOpen Closed
    2010-01-13 None Attached File- Added ClefChooser2, #19480
    2010-01-13 None Attached File- Added ClefChooser2, #19479
    2009-11-08 rshann StatusNone Fixed

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code