bugMIT/GNU Scheme - Bugs: bug #27887, i386 assembly hook for generic...

 
 

bug #27887: i386 assembly hook for generic multiplication multiplies fixnums incorrectly

Submitter:  Taylor R. Campbell <riastradh>
Submitted:  Fri 30 Oct 2009 09:24:55 PM UTC
   
 
Category:  microcode Severity:  2 - Minor
Priority:  5 - Normal Item Group:  Incorrect behavior
Status:  Fixed Privacy:  Public
Assigned to:  riastradh Originator Name: 
Open/Closed:  Closed
Keywords: 
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 12 Nov 2009 09:55:29 PM UTC, comment #1: 

Fixed in commit 84b1f57fbe67265816dde2cec64786e09ddcf349.

Taylor R. Campbell <riastradh>
Group Member
Fri 30 Oct 2009 09:24:55 PM UTC, original submission:  

((fluid-let ((compiler:open-code-primitives? #f))
   (compile-procedure
    (eval `(LAMBDA (X Y) (,(make-primitive-procedure '&*) X Y))
          (nearest-repl/environment))))
 1
 2)
;Value: 128

This is a reminder to me to commit the fix (shift EAX right by 6 before IMUL), once I have cleaned up a large number of other changes that it shouldn't get swept into.

(This doesn't really matter at all -- nobody ever inhibits open-coding of primitives, so that the fixnum case is always open-coded and the assembly hook's fixnum case is never used.  So this bug has lain dormant for fifteen years.)

Taylor R. Campbell <riastradh>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by riastradh (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2009-11-12 riastradh StatusNone Fixed
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code