bugmake - Bugs: bug #24655, shell_var.length isn't set causing...


bug #24655: shell_var.length isn't set causing duplicates from target_environment.

Submitter:  Knut St. Osmundsen <bird_tori>
Submitted:  Sun 26 Oct 2008 10:02:30 PM UTC
Severity:  3 - Normal Item Group:  Bug
Status:  Fixed Privacy:  Public
Assigned to:  psmith Open/Closed:  Closed
Component Version:  3.81 Operating System:  Any
Fixed Release:  3.82 Triage Status:  None
* Mandatory Fields

Add a New Comment Rich Markup

Thu 04 Jun 2009 05:48:49 AM UTC, comment #1: 

I can't reproduce the problem (I don't get failures in the SHELL unit tests) but I agree that the change you proposed is necessary and I've made it in the source code.

Paul D. Smith <psmith>
Group administrator
Sun 26 Oct 2008 10:02:30 PM UTC, original submission:  

target_environment() uses a temporary hash table for collecting exported variables from the sets.   This table uses variable_hash_1 and variable_hash_2 which expect the struct variable::length field to be correct and will generate incorrect values for the shell_var since its length field is 0.

The result is, for instance, that the last test in tests/scripts/variables/SHELL exports the wrong SHELL variable.

The fix is very simple, just initialize shell_var.length to 5 in main.c (line 1189 in r1.227).

Knut St. Osmundsen <bird_tori>


(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:

No files currently attached


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -email is unavailable- added by psmith (Posted a comment)
  • -email is unavailable- added by bird_tori (Submitted the item)

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.


    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-07-28 psmith Fixed Release4.0 3.82
    2009-06-04 psmith StatusNone Fixed
        Assigned toNone psmith
        Open/ClosedOpen Closed
        Fixed ReleaseNone 4.0

    Back to the top

    Powered by Savane 3.13-0159.
    Corresponding source code