bugGNU Screen - Bugs: bug #24112, NULL pointer dereference in help...

 
 

bug #24112: NULL pointer dereference in help screen when you have a nested window

Submitter:  None
Submitted:  Thu 21 Aug 2008 01:24:50 AM UTC
   
 
Category:  Crash/Freeze/Infloop Severity:  4 - Important
Priority:  * 7 - High Status:  Invalid
Privacy:  Public Assigned to:  sadrul
Open/Closed:  Closed Release:  Cur Dev Sources
Fixed Release:  None Planned Release:  4.1.0
Work Required:  0 - Hours
* Mandatory Fields

Add a New Comment Rich Markup
   

Sun 28 Mar 2010 01:41:37 AM UTC, comment #3: 

The window list (and display list) has been effectively re-written. So this is not valid anymore.

Of course, if you find a crash in the current windowlist, please file a new issue. Thanks!

Sadrul Habib Chowdhury <sadrul>
Group administrator
Tue 26 Aug 2008 12:38:03 PM UTC, comment #2: 

Sorry, I posted an incomplete bug report last time.  The code in question is in WListLine(), where it's iterating through group parents to obtain indentation level:

    for (group = wtab[i]->w_group, xoff = 0;
         group != wlistdata->group;
          group = group->w_group, xoff += 2)

As it's using wlistdata->group as sentinel, it must be set to either NULL, or one of the group parents, or the iteration reaches the root, where group->w_group == NULL.
Too bad, I lost the core file, but I'll try to reproduce it anyway; it only took me several keystrokes before catching SIGSEGV, it shouldn't be too difficult.

YONETANI Tomokazu <y0netan1>
Thu 21 Aug 2008 02:30:40 PM UTC, comment #1: 

Thanks!

Is there a way to reproduce the crash?

Sadrul Habib Chowdhury <sadrul>
Group administrator
Thu 21 Aug 2008 01:24:50 AM UTC, original submission:  

Attached is a patch I'm using as a bandaid.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #16325:  help.c.diff added by None (488B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by y0netan1 (Posted a comment)
  • -email is unavailable- added by sadrul (Posted a comment)
  • -email is unavailable- added by micahcowan (Updated the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 9 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-03-28 sadrul StatusNeed Investigation Invalid
        Open/ClosedOpen Closed
    2008-08-21 sadrul Assigned toNone sadrul
    2008-08-21 micahcowan Severity3 - Normal 4 - Important
        Priority5 - Normal 7 - High
        StatusNone Need Investigation
        Planned ReleaseNone 4.1.0
        Work RequiredNone 0 - Hours
    2008-08-21 None Attached File- Added help.c.diff, #16325

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code