bugmake - Bugs: bug #21824, Another potential NULL ptr...


bug #21824: Another potential NULL ptr dereference, on remake.c

Submitter:  Marcio Buss <marciobuss>
Submitted:  Tue 18 Dec 2007 03:33:50 AM UTC
Severity:  3 - Normal Item Group:  Bug
Status:  Fixed Privacy:  Public
Assigned to:  psmith Open/Closed:  Closed
Component Version:  None Operating System:  None
Fixed Release:  3.82 Triage Status:  None
* Mandatory Fields

Add a New Comment Rich Markup

Sun 02 Aug 2009 11:30:27 PM UTC, comment #1: 

Fixed; thanks.

Paul D. Smith <psmith>
Group administrator
Tue 18 Dec 2007 03:33:50 AM UTC, original submission:  

There's a potential null pointer dereference also in remake.c
The error can be tracked down as follows:

(1) Assume the first conjunct is false in the test
    "if (file->cmds != 0 && file->cmds->any_recurse)"
    This implies that file->cmds is NULL.

(2) item (1) implies that the "if" statement evaluates to
    false, and the else branch executes.

(3) we continue the execution till we get to line 861, where
    "file->cmds" is dereferenced at statement
    "if (! (file->cmds->lines_flags[i-1] & COMMANDS_RECURSE))"

Marcio Buss <marciobuss>


(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:

No files currently attached


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -email is unavailable- added by psmith (Posted a comment)
  • -email is unavailable- added by marciobuss (Submitted the item)
  • -email is unavailable- added by marciobuss

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.


    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-07-28 psmith Fixed Release4.0 3.82
    2009-08-02 psmith Assigned toNone psmith
        Open/ClosedOpen Closed
        Fixed ReleaseNone 4.0
        StatusNone Fixed
    2007-12-18 marciobuss Carbon-Copy- Added -email is unavailable-

    Back to the top

    Powered by Savane 3.13-ee12.
    Corresponding source code