bugPSPP - Bugs: bug #21111, INPUT PROGRAM breakage

 
 

bug #21111: INPUT PROGRAM breakage

Submitted by:  Ben Pfaff <blp>
Submitted on:  Tue 18 Sep 2007 04:29:18 PM UTC  
 
Category:  Syntax Parser Severity:  7 - Major
Status:  Fixed Assigned to:  Ben Pfaff <blp>
Open/Closed:  Closed Release:  Before 0.6.0
Effort:  0.00

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Sun 23 Sep 2007 04:50:00 PM UTC, comment #10: 

Thanks John, I checked both of these in.

Ben Pfaff <blp>
Project AdministratorIn charge of this item.
Sun 23 Sep 2007 06:56:10 AM UTC, comment #9: 

Looks good to me.

John Darrington <jmd>
Project Administrator
Sun 23 Sep 2007 06:49:12 AM UTC, comment #8: 

>I think it'll be kinder to the user if we phrase the error message
>in a positive sense.


OK.  Revised version attached.

(file #14013)

Ben Pfaff <blp>
Project AdministratorIn charge of this item.
Sun 23 Sep 2007 06:42:04 AM UTC, comment #7: 

I think it'll be kinder to the user if we phrase the error message in a positive sense. Ie:

 "The END keyword may be used only with DATA LIST FIXED."

John Darrington <jmd>
Project Administrator
Sun 23 Sep 2007 06:08:36 AM UTC, comment #6: 

>Confusing results still occur if you try to use DATA LIST
>{LIST,FREE} in conjunction with END. Other software prohibits this
>combination. Perhaps we should too?


Sure.  Additional patch attached for review.

(file #14012)

Ben Pfaff <blp>
Project AdministratorIn charge of this item.
Sun 23 Sep 2007 05:33:25 AM UTC, comment #5: 

This patch looks good.

Confusing results still occur if you try to use DATA LIST {LIST,FREE} in conjunction with END.  Other software prohibits this combination. Perhaps we should too?

John Darrington <jmd>
Project Administrator
Sun 23 Sep 2007 04:49:16 AM UTC, comment #4: 

Here's a fix.  It turned out that part of the problem was a buggy implementation of DO IF, so I added a test for DO IF also.

(file #14010)

Ben Pfaff <blp>
Project AdministratorIn charge of this item.
Fri 21 Sep 2007 05:24:16 AM UTC, comment #3: 

>This patch seems to improve things for me.
>Comments?


Before the patch, test1 passes, test2 fails, test3 hangs, test4 fails, and test5 passes.

After the patch, test2 passes, test4 hangs, and the others are unchanged.

It is a minor improvement, but I'd rather make everything pass :-)  I'll try to devise a full fix later.

Ben Pfaff <blp>
Project AdministratorIn charge of this item.
Fri 21 Sep 2007 05:18:12 AM UTC, comment #2: 

Here's a patch that adds the INPUT PROGRAM examples as regression tests.  As you note, most of them don't pass.

(file #14003)

Ben Pfaff <blp>
Project AdministratorIn charge of this item.
Fri 21 Sep 2007 05:00:15 AM UTC, comment #1: 

This patch seems to improve things for me.

Comments?

(file #14002)

John Darrington <jmd>
Project Administrator
Tue 18 Sep 2007 04:29:18 PM UTC, original submission:  

From John Darrington:

>I'm unable to get most of the examples in the INPUT PROGRAM
>section of the manual to work as described.


Need to test these, fix the bugs, and add them under tests/command.

Ben Pfaff <blp>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #14010:  input-program-tests-2.patch added by blp (14KiB - text/x-diff)
file #14003:  input-program-tests.patch added by blp (8KiB - text/x-diff)
file #14002:  data-list-end.patch added by jmd (3KiB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jmd (Updated the item)
  • -email is unavailable- added by blp (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 10 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-09-23 blp StatusReady for Test/Review => Fixed
        Open/ClosedOpen => Closed
    2007-09-23 blp Attached File- => Added data-list-end-fixed-only.patch, #14013
    2007-09-23 blp Attached File#14012 => Removed
    2007-09-23 blp Attached File- => Added data-list-end-fixed-only.patch, #14012
    2007-09-23 blp Attached File- => Added input-program-tests-2.patch, #14010
        StatusNone => Ready for Test/Review
    2007-09-21 blp Attached File- => Added input-program-tests.patch, #14003
    2007-09-21 jmd Attached File- => Added data-list-end.patch, #14002
    2007-09-18 blp ReleaseNone => Before 0.6.0

    Back to the top


    Powered by Savane 3.6