bugPSPP - Bugs: bug #18922, Crashes if filenames differ only...

 
 

bug #18922: Crashes if filenames differ only in case.

Submitter:  John Darrington <jmd>
Submitted:  Thu 01 Feb 2007 03:59:20 AM UTC
   
 
Category:  Syntax Parser Severity:  5 - Average
Status:  Fixed Assigned to:  None
Open/Closed:  Closed Release:  None
Effort:  0.00
* Mandatory Fields

Add a New Comment Rich Markup
   

Fri 02 Feb 2007 12:57:36 AM UTC, comment #3: 

We believe that this problem is fixed in a change recently
checked into the CVS respository.  If you discover that the bug
has not been fixed, please re-open the bug.

Thank you for your help in improving PSPP.

Ben Pfaff <blp>
Group administrator
Fri 02 Feb 2007 12:26:01 AM UTC, comment #2: 

works for me.

John Darrington <jmd>
Group administrator
Thu 01 Feb 2007 05:42:29 PM UTC, comment #1: 

The problem is that we're using a single member in struct file_handle, the "name" field, for more than one purpose.  When it begins with '"', it's a file name; otherwise, it's a token that can be used to identify it.  When that assertion fires, it's because we searched for the name case-sensitively as a file name (so that there was no match), and then we try to insert it case-insensitively as a token, which fails because duplicates aren't allowed.

Solution: break the two purposes into two separate fields.  This fixes the problem and likely makes the code easier to read too.

Patch attached.

(file #11906)

Ben Pfaff <blp>
Group administrator
Thu 01 Feb 2007 03:59:20 AM UTC, original submission:  

This code causes an assertion failure.  It works if the two filenames have the same orthography.

data list list /x *.
begin data.
1
2
3
4
end data.

save outfile 'data.sav'.


MATCH
  FILES FILE='DATA.SAV'
  /BY x.

LIST.

John Darrington <jmd>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #11906:  fh-crash.patch added by blp (9KiB - text/x-patch - fix)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by blp (Updated the item)
  • -email is unavailable- added by jmd (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-02-02 blp StatusReady for Test/Review Fixed
        Open/ClosedOpen Closed
    2007-02-01 blp Attached File- Added fh-crash.patch, #11906
        StatusNone Ready for Test/Review

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code