bugmake - Bugs: bug #18680, fix for bug#2846 does not work as...

 
 

bug #18680: fix for bug#2846 does not work as expected, still hang sometimes

Submitter:  None
Submitted:  Wed 03 Jan 2007 02:06:34 PM UTC
   
 
Severity:  3 - Normal Item Group:  Bug
Status:  Fixed Privacy:  Public
Assigned to:  psmith Open/Closed:  Closed
Component Version:  3.81 Operating System:  POSIX-Based
Fixed Release:  3.82 Triage Status:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 04 Jan 2007 01:58:39 AM UTC, comment #1: 

Doh!  Silly.  As a lame excuse I'll mention that the original fix was for situations where errno was not 0 before invoking the macro, not where it was set to 0 inside the macro.  However it should have been obvious that the latter was necessary as well.

Fix applied.

Paul D. Smith <psmith>
Group administrator
Wed 03 Jan 2007 02:06:34 PM UTC, original submission:  

The macro ENULLLOOP in make.h does not work as expected to be fixed in bug #2846.
If "_c" returns zero with errno=EINTR when called first, the inner while-loop repeats calling "_c", but without setting errno=0 before the next call.
So errno keeps being EINTR, while "_c" already succeeds, and make run into an endless loop.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #11674:  make-3.81-eintr-loop.patch added by None (421B - text/x-patch - Patch for reworked ENULLLOOP macro)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by psmith (Posted a comment)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-07-28 psmith Fixed Release4.0 3.82
    2007-01-04 psmith StatusNone Fixed
        Assigned toNone psmith
        Open/ClosedOpen Closed
        Fixed ReleaseNone 4.0
    2007-01-03 None Attached File- Added make-3.81-eintr-loop.patch, #11674

    Back to the top

    Powered by Savane 3.13-7c56.
    Corresponding source code