bugPSPP - Bugs: bug #18533, RANK should allow string grouping...

 
 

bug #18533: RANK should allow string grouping variables

Submitter:  Ben Pfaff <blp>
Submitted:  Fri 15 Dec 2006 08:30:25 PM UTC
   
 
Category:  Syntax Parser Severity:  5 - Average
Status:  Fixed Assigned to:  blp
Open/Closed:  Closed Release:  None
Effort:  0.00
* Mandatory Fields

Add a New Comment Rich Markup
   

Sat 16 Dec 2006 08:57:30 PM UTC, comment #2: 

We believe that this problem is fixed in a change recently
checked into the CVS respository.  If you discover that the bug
has not been fixed, please re-open the bug.

Thank you for your help in improving PSPP.

Ben Pfaff <blp>
Group administrator
Sat 16 Dec 2006 08:29:48 AM UTC, comment #1: 

I can't see any problems either.

John Darrington <jmd>
Group administrator
Fri 15 Dec 2006 08:30:25 PM UTC, original submission:  

I don't see a reason why grouping variables shouldn't be strings. This patch seems to be all that is needed:

--- rank.q.~1.21.~      2006-12-09 21:37:26.000000000 -0800                                                                                              
+++ rank.q      2006-12-15 12:22:50.000000000 -0800                                                                                                      
@@ -953,7 +954,7 @@ rank_custom_variables (struct lexer *lex
                                                                                                                                                         
       if (!parse_variables (lexer, dataset_dict (ds),                                                                                                   
                            &group_vars, &n_group_vars,                                                                                                  
-                           PV_NO_DUPLICATE | PV_NUMERIC | PV_NO_SCRATCH) )                                                                              
+                           PV_NO_DUPLICATE | PV_NO_SCRATCH) )                                                                                           
        {                                                                                                                                                
          free (group_vars);                                                                                                                             
          return 0;                                                                                                                                      

Ben Pfaff <blp>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jmd (Posted a comment)
  • -email is unavailable- added by blp (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2006-12-16 blp StatusNone Fixed
        Open/ClosedOpen Closed
    2006-12-16 jmd Assigned tojmd blp

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code