bugmake - Bugs: bug #17381, Compile errors under DJGPP

 
 

bug #17381: Compile errors under DJGPP

Submitter:  None
Submitted:  Tue 08 Aug 2006 11:03:14 PM UTC
   
 
Severity:  3 - Normal Item Group:  Build/Install
Status:  Fixed Privacy:  Public
Assigned to:  eliz Open/Closed:  Closed
Component Version:  3.81 Operating System:  MS-DOS
Fixed Release:  3.82 Triage Status:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 12 Jul 2010 07:07:27 PM UTC, comment #3: 

The MS-DOS build does not call child_execute_job at all.  In Make 3.81, the definition of the function was mistakenly conditioned on _MSDOS_ as well.  Now it is only defined on other systems.  So this patch is not needed.

I'm closing this report.

Eli Zaretskii <eliz>
Group Member
Mon 12 Jul 2010 06:00:27 PM UTC, comment #2: 

Eli: I don't see this patch in the current CVS version.  Is this still needed?

Thanks!

Paul D. Smith <psmith>
Group administrator
Sat 12 Aug 2006 12:48:22 PM UTC, comment #1: 

The following patch should take care of this:

2006-08-12  Eli Zaretskii  <eliz@gnu.org>

  • job.h [__MSDOS__]: Use the same prototype for child_execute_job as _EMX_ does.



--- job.h~0 2006-02-12 02:16:04.000000000 +0200
+++ job.h 2006-08-12 15:44:06.875000000 +0300
@@ -73,7 +73,7 @@
 extern char *construct_command_argv PARAMS ((char *line, char *restp, struct file file, char* batch_file));
 #ifdef VMS
 extern int child_execute_job PARAMS ((char *argv, struct child *child));
-#elif defined(_EMX_)
+#elif defined(_MSDOS_) || defined(_EMX_)
 extern int child_execute_job PARAMS ((int stdin_fd, int stdout_fd, char *argv, char *envp));
 #else
 extern void child_execute_job PARAMS ((int stdin_fd, int stdout_fd, char *argv, char *envp));

Eli Zaretskii <eliz>
Group Member
Tue 08 Aug 2006 11:03:14 PM UTC, original submission:  

Having run sh ./configure the makefile is produced successfully.
However, executing make results in the following error:

job.c:1898: error: conflicting types for 'child_execute_job'
job.h:79: error: previous declaration of 'child_execute_job' was here
job.c: In function 'child_execute_job':
job.c:1931: error: void value not ignored as it ought to be

Entire log attached as text file.

Notably, using exactly the same procedure the v3.80 compiles... but then again there are extra #ifdef conditions in v3.81.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #10497:  log.txt added by None (2KiB - text/plain - Make log)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by eliz (Posted a comment)
  • -email is unavailable- added by psmith (Posted a comment)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-07-28 psmith Fixed Release4.0 3.82
    2010-07-12 psmith StatusNone Fixed
        Fixed ReleaseNone 4.0
    2010-07-12 eliz Open/ClosedOpen Closed
        Operating SystemMS Windows MS-DOS
    2010-07-12 psmith Assigned toNone eliz
    2006-08-08 None Attached File- Added log.txt, #10497

    Back to the top

    Powered by Savane 3.13-12ab.
    Corresponding source code