bugPSPP - Bugs: bug #17238, Errors should go to the output file

 
 

bug #17238: Errors should go to the output file

Submitted by:  Ben Pfaff <blp>
Submitted on:  Mon 31 Jul 2006 02:13:17 AM UTC  
 
Category:  Output Driver Severity:  1 - Wishlist
Status:  Fixed Assigned to:  Ben Pfaff <blp>
Open/Closed:  Closed Release:  Before 0.6.0
Effort:  0.00

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Sun 26 Aug 2007 06:36:31 PM UTC, comment #7: 

I committed these patches.  Thanks!

Ben Pfaff <blp>
Project AdministratorIn charge of this item.
Sun 26 Aug 2007 03:59:49 AM UTC, comment #6: 

Looks fine to me.

John Darrington <jmd>
Project Administrator
Sun 26 Aug 2007 12:17:48 AM UTC, comment #5: 

OK, I respun the patch and added a second patch (which should be applied second) that implements your suggestions.

(file #13801, file #13802)

Ben Pfaff <blp>
Project AdministratorIn charge of this item.
Mon 13 Aug 2007 11:45:33 PM UTC, comment #4: 

> How about if, with --testing-mode, we ignore the configuration files and use a builtin configuration?


That's a good idea.  We should also change most of the tests so that
PSPP="$top_builddir/src/ui/terminal/pspp --testing-mode"

John Darrington <jmd>
Project Administrator
Sun 12 Aug 2007 11:57:36 PM UTC, comment #3: 

>This probably means that we ought to change the tests so that they
>use the config directory of the tree under test instead of the
>user's.


I agree that something like that is a good idea.

How about if, with --testing-mode, we ignore the configuration files and use a builtin configuration?

Ben Pfaff <blp>
Project AdministratorIn charge of this item.
Sun 12 Aug 2007 11:37:30 PM UTC, comment #2: 

>  To keep tests from failing after applying the patch, you need to also apply the change to your installed "devices" configuration file.


This probably means that we ought to change the tests so that they use the config directory of the tree under test instead of the user's.

John Darrington <jmd>
Project Administrator
Sun 12 Aug 2007 10:26:47 PM UTC, comment #1: 

This turned out to be almost trivial.  Patch attached.

To keep tests from failing after applying the patch, you need to also apply the change to your installed "devices" configuration file.

(file #13653)

Ben Pfaff <blp>
Project AdministratorIn charge of this item.
Mon 31 Jul 2006 02:13:17 AM UTC, original submission:  

Errors should go to output files as well as to the console.  (This behavior should be controllable by SET ERRORS.)

Ben Pfaff <blp>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jmd (Posted a comment)
  • -email is unavailable- added by blp (Updated the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-08-26 blp StatusReady for Test/Review => Fixed
        Open/ClosedOpen => Closed
    2007-08-26 blp Attached File- => Added errors-should-go-to-output.patch, #13801
        Attached File- => Added testing-mode-builtin-config.patch, #13802
    2007-08-26 blp Attached File#13653 => Removed
    2007-08-12 blp Attached File- => Added errors-should-go-to-output.patch, #13653
        StatusNone => Ready for Test/Review
    2006-07-31 blp ReleaseNone => Before 0.6.0

    Back to the top


    Powered by Savane 3.6