bugmake - Bugs: bug #12686, make quietly dies instead of...

 
 

bug #12686: make quietly dies instead of issuing an error

Submitter:  Boris Kolpackov <bosk>
Submitted:  Thu 14 Apr 2005 12:32:32 PM UTC
   
 
Severity:  4 - Important Item Group:  Bug
Status:  Fixed Privacy:  Public
Assigned to:  bosk Open/Closed:  Closed
Component Version:  3.81 Operating System:  Any
Fixed Release:  3.82 Triage Status:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 30 Sep 2009 10:01:06 AM UTC, comment #1: 

Fix is in CVS.

Boris Kolpackov <bosk>
Group Member
Thu 14 Apr 2005 12:32:32 PM UTC, original submission:  

$ rm bar
$ cat >makefile

all: bar
        @echo $@

foo: bar
        touch $@

-include foo

$ make || echo failed
failed

$ make -rd
Reading makefiles...
Reading makefile `makefile'...
Reading makefile `foo' (search path) (don't care) (no ~ expansion)...
Updating makefiles....
 Considering target file `foo'.
  File `foo' does not exist.
   Considering target file `bar'.
    File `bar' does not exist.
    Looking for an implicit rule for `bar'.
    No implicit rule found for `bar'.
    Finished prerequisites of target file `bar'.
   Must remake target `bar'.
   Failed to remake target file `bar'.
  Finished prerequisites of target file `foo'.
 Giving up on target file `foo'.
 Considering target file `makefile'.
  Looking for an implicit rule for `makefile'.
  No implicit rule found for `makefile'.
  Finished prerequisites of target file `makefile'.
 No need to remake target `makefile'.
Updating goal targets....
Considering target file `all'.
 File `all' does not exist.
  Pruning file `bar'
 Finished prerequisites of target file `all'.
Giving up on target file `all'.

In words the problem lies in the fact that make prunes subgraphs (bar in our case) that may have been built with different dont_care flag (remake.c:update_file, line 295).

There is also a piece of code below (remake.c:update_file_1, line 381) that seem to be dealing with similar (the same?) situation. Should it be duplicated in update_file or maybe moved? It seems to me that file->considered and file->updated have somewhat similar roles.

Paul, any thoughts?

Boris Kolpackov <bosk>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by psmith (Updated the item)
  • -email is unavailable- added by bosk (Posted a comment)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-07-28 psmith Fixed Release4.0 3.82
    2009-09-30 bosk Component Version4.0 3.81
        Fixed ReleaseNone 4.0
        Open/ClosedOpen Closed
        StatusNone Fixed
    2005-05-09 bosk Assigned toNone bosk

    Back to the top

    Powered by Savane 3.13-599c.
    Corresponding source code