patchGNU Octave - Patches: patch #9061, generate_html: fixing bug in...

 
 

patch #9061: generate_html: fixing bug in generate_package_html when no exist url field

Submitter:  Fernando Pujaico Rivera <trucomanx>
Submitted:  Thu 28 Jul 2016 05:44:06 PM UTC
   
 
Category:  Forge : other Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Tue 10 Apr 2018 05:57:30 AM UTC, comment #2: 

This has been fixed in the generate_html package.

Mike Miller <mtmiller>
Group Member
Thu 28 Jul 2016 07:01:03 PM UTC, comment #1: 

The code was found in the generate_package_html.m file in the line 518

Fernando Pujaico Rivera <trucomanx>
Thu 28 Jul 2016 05:44:06 PM UTC, original submission:  


In the version 0.1.12 of generate_html package
we have the next code

    if (isfield (list, "url")) && (! isempty (list.url))
      index_write_homepage_links (fid, list.url);
    endif

but, in the current source code version we have:

    if (! isempty (list.url))
      index_write_homepage_links (fid, list.url);
    endif


It is wrong no verify first if exist the url field.

I adding a patch, but you can fix it manually.

Fernando Pujaico Rivera <trucomanx>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #38042:  bug-no-url.diff added by trucomanx (876B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by trucomanx (Submitted the item)
  • -email is unavailable- added by trucomanx (generate_html: fixing bug in generate_package_html when no exist url field)
  • -email is unavailable- added by trucomanx (generate_html: fixing bug in generate_package_html when no exist url field)
  • -email is unavailable- added by trucomanx (generate_html: fixing bug in generate_package_html when no exist url field)
  • -email is unavailable- added by trucomanx (generate_html: fixing bug in generate_package_html when no exist url field)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 9 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-03-07 mtmiller Carbon-CopyRemoved 80942 -
    2018-04-10 mtmiller CategoryNone Forge : other
        StatusNone Done
        Open/ClosedOpen Closed
    2016-07-28 trucomanx Attached File- Added bug-no-url.diff, #38042
        Carbon-Copy- Added -email is unavailable-
        Carbon-Copy- Added -email is unavailable-
        Carbon-Copy- Added -email is unavailable-
        Carbon-Copy- Added -email is unavailable-

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code