patchGNUstep - Patches: patch #7470, Fix mouse behaviour in Windows 95...

Group
 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #7470: Fix mouse behaviour in Windows 95 and Macintosh menu styles

Submitter:  Chris Armstrong <carmstrong>
Submitted:  Thu 17 Feb 2011 11:30:24 AM UTC
   
 
Category:  AppKit Priority:  5 - Normal
Status:  Ready For Test Privacy:  Public
Assigned to:  FredKiefer Open/Closed:  Closed

Tue 22 Feb 2011 12:34:48 AM UTC, comment #3: 

I submitted your patch and hope that enough people will test it before the next GNUstep release.

Fred Kiefer <FredKiefer>
Group Member
Sun 20 Feb 2011 03:33:08 PM UTC, comment #2: 

I still don't like the _captureMouse: call, but at least this is now implemented safely.

There is a lot that I don't understand about this long method, but one line seems to be obviously wrong. That is the stopping of periodic events. Why is this done here as well as outside of this method? But this hasn't changed with your patch, you may as well just leave it broken.

Fred Kiefer <FredKiefer>
Group Member
Sun 20 Feb 2011 12:03:57 PM UTC, comment #1: 

I just added a newer patch that addresses:

  • Menus not closing properly after moving mouse upwards and across the main window menu
  • Capture/Release mouse now isolated in a wrapper method.
Chris Armstrong <carmstrong>
Thu 17 Feb 2011 11:30:24 AM UTC, original submission:  

This patch is fixes some menu behaviours with the Macintosh and Windows 95 modes.

The addressed issues are:

Add support detecting when the mouse is released outside of a menu window or normal window for closing an attached menu. At the moment, clicking outside the menu or on a non-GNUstep window does not close the menus. This solution also fixes a similar issue with popup menus in all menu styles.

The next bit is for when Windows 95 mode where the menus have been open by a mouse click (not a mouse click and drag). If you move the mouse outside the attached menu window, it closes the menu.

The last bit keeps the sub-menu open when you move the mouse outside of it until you select another top-level menu or go back to the sub-menu when in Windows-95 mode. This more closely emulates Windows behaviour.


Chris Armstrong <carmstrong>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by FredKiefer (Posted a comment)
  • -email is unavailable- added by carmstrong (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2011-02-22 FredKiefer StatusNone Ready For Test
        Assigned toNone FredKiefer
        Open/ClosedOpen Closed
    2011-02-20 carmstrong Attached File- Added 006-win95_mac_and_menus_close_highlightlogic_and_capture_protection.patch, #22739
    2011-02-17 carmstrong Attached File- Added 003-win95_and_mac_menus_close_fix_clean.diff, #22711

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code