patchDotGNU Portable.NET - Patches: patch #5516, Fix non-networked profiles

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #5516: Fix non-networked profiles

Submitter:  Roman I Khimov <roman_khimov>
Submitted:  Thu 02 Nov 2006 03:43:55 PM UTC
 
Category:  None Priority:  4
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       No canned response available

 

Fri 03 Nov 2006 08:11:59 PM UTC, comment #5: 

Applied to cvs 11/02/06.

We left the code for setting the hostname via am environment variable if networking is not supported.

Klaus Treichel <ktreichel>
Project Administrator
Thu 02 Nov 2006 08:40:11 PM UTC, comment #4: 

I don't think it makes much sense. We have no networking support, why should we have domain and host names?

Roman I Khimov <roman_khimov>
Thu 02 Nov 2006 08:13:56 PM UTC, comment #3: 

Should we keep the evaluation of the environment var for non networked profiles to allow setting of the name in the environment ?

Klaus Treichel <ktreichel>
Project Administrator
Thu 02 Nov 2006 07:02:49 PM UTC, comment #2: 

Good point. I've updated patch.

Roman I Khimov <roman_khimov>
Thu 02 Nov 2006 06:44:00 PM UTC, comment #1: 

The file int_table.c is generated with the shell script mkint.sh and must not be modified manually.

Instead of removing the functions completely i would add this code instead for non networking builds.
This will throw a NotSupportedException to the application if one of the methods is called.

ILExecThreadThrowSystem(thread, "System.NotSupportedException",
"Exception_ThreadsNotSupported");
return 0;

Klaus Treichel <ktreichel>
Project Administrator
Thu 02 Nov 2006 03:43:55 PM UTC, original submission:  

Looks like non-networking profiles are currently broken because of
_IL_InfoMethods_GetNetBIOSMachineName function in engine:

gcc -DHAVE_CONFIG_H -I. -I. -I../include    -I../libffi/include -fno-gcse -fno-inline-functions                         -fno-unit-at-a-time -I../support       -I../libgc/include -I../include                                          -I../libffi/include -I. -DBUILD_PROFILE_NAME="\"kernel-fp\"" -g -O2 -Wall -c ilrun.c
gcc -I../libffi/include -fno-gcse -fno-inline-functions                        -fno-unit-at-a-time -I../support                         -I../libgc/include -I../include                                                 -I../libffi/include -I. -DBUILD_PROFILE_NAME="\"kernel-fp\"" -g -O2 -Wall  -o ilrun  ilrun.o libILEngine.a ../dumpasm/libILDumpAsm.a                      ../image/libILImage.a ../support/libILSupport.a                             -ltermcap  -lz -lnsl -ldl -lm
libILEngine.a(lib_info.o): In function `_IL_InfoMethods_GetNetBIOSMachineName':/home/rik/itmo/diploma/work/dotgnu-host/pnet/engine/lib_info.c:58: undefined reference to `_IL_DnsMethods_InternalGetHostName'
collect2: ld returned 1 exit status

I don't think it's needed for non-networked profile, so this patch just
disables it along with _IL_InfoMethods_GetUserDomainName function that
calls it.

Roman I Khimov <roman_khimov>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

Only logged-in users can vote.

 

 

 

 

Follow 4 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2006-11-03 ktreichel StatusNone Done
    Open/ClosedOpen Closed
2006-11-02 roman_khimov Attached File- Added fix_network_disabled_profiles-try2.patch, #11142
2006-11-02 roman_khimov Attached File- Added fix_network_disabled_profiles.patch, #11140

Back to the top


Powered by Savane 3.9