findutils - Patches: patch #9754, find: new '-attr' predicate to...
You are not allowed to post comments on this tracker with your current authentication level.
patch #9754: find: new '-attr' predicate to test inode flags
Submitter: | Matt Whitlock <mwhitlock> | ||
Submitted: | Thu 31 Jan 2019 02:03:43 AM UTC | ||
Category: | find enhancement | Priority: | 5 - Normal |
Status: | None | Privacy: | Public |
Assigned to: | None | Originator Name: | |
Open/Closed: | Open | Release: | None |
Fixed Release: | None |
Tue 23 Apr 2019 04:01:50 AM UTC, comment #2: |
Matt Whitlock <mwhitlock> |
Sat 09 Feb 2019 04:43:53 PM UTC, comment #1: Thanks for the patch.
|
Bernhard Voelker <berny>![]() |
Thu 31 Jan 2019 02:03:43 AM UTC, original submission:
On my system, I frequently need to find files having (or lacking) a particular file attribute. To date, I have implemented this with relatively gross pipelines like the following:
|
Matt Whitlock <mwhitlock> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 2 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2019-04-23 | mwhitlock | Attached File | - | ![]() |
Added 0002-find-support-attr-only-if-OS-supports-inode-flags.patch, #46811 |
2019-01-31 | mwhitlock | Attached File | - | ![]() |
Added 0001-find-introduce-attr-predicate-to-test-inode-flags.patch, #46138 |
Inode flags are not specific to Linux's Extended File System, but they are specific to Linux. They were lifted from Ext to Linux's (filesystem-agnostic) VFS layer because they're used by multiple file system implementations. The following note from <linux/fs.h> may be instructive:
As it happens, I mostly use these flags on XFS volumes.
Regarding the "Casefold" and "Verity" flags you mentioned, I do not see these in the <linux/fs.h> header. I would guess that they are specific to Ext and are accessed by filesystem-specific APIs. If they are ever promoted to the VFS layer, then it might make sense to add them to Find.
I have added an Autoconf check and preprocessor guard directives so that -attr is implemented only on systems with a working <linux/fs.h> header.
I do not see the code style warnings that you quoted, but I have incorporated fixes that should eliminate them.
I am indeed willing to assign copyrights for my contribution to the Free Software Foundation.
(file #46811)