GNU nano - Patches: patch #9621, fix a segfault in the search for...
You are not allowed to post comments on this tracker with your current authentication level.
patch #9621: fix a segfault in the search for word completions
Submitter: | easyaspi314 <easyaspi314> | ||
Submitted: | Mon 23 Apr 2018 12:39:06 AM UTC | ||
Priority: | 7 - High | Status: | Done |
Privacy: | Public | Assigned to: | bens |
Open/Closed: | Closed | Release: | None |
Jump to the original submission
Mon 23 Apr 2018 03:25:20 PM UTC, comment #6: |
Benno Schulenberg <bens> |
Mon 23 Apr 2018 02:51:42 PM UTC, comment #5: Well, I am a little confused about why this is the case:
|
easyaspi314 <easyaspi314> |
Mon 23 Apr 2018 12:23:45 PM UTC, comment #4: The segfault is prevented by forcing a signed comparison. See attached patch. |
Benno Schulenberg <bens> |
Mon 23 Apr 2018 12:14:53 PM UTC, comment #3: Oh wow. When I type s, and then ^] ^] ^] ^] ^], I get:
|
Benno Schulenberg <bens> |
Mon 23 Apr 2018 12:05:49 PM UTC, comment #2: Simple.
|
easyaspi314 <easyaspi314> |
Mon 23 Apr 2018 08:22:59 AM UTC, comment #1: Do you have a reproduction recipe for the crash?
|
Benno Schulenberg <bens> |
Mon 23 Apr 2018 12:39:06 AM UTC, original submission:
I don't know why the for loop continues to execute, but if threshold is negative, which it appears to be at the end of the list, we get a segfault after reading a bunch of stuff out of bounds.
|
easyaspi314 <easyaspi314> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 8 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2018-04-29 | bens | Open/Closed | Open | Closed | |
2018-04-23 | bens | Status | In Progress | Done | |
2018-04-23 | easyaspi314 | Attached File | - | Added errors.txt, #43993 | |
2018-04-23 | bens | Attached File | - | Added avoid-completion-crash.patch, #43991 | |
2018-04-23 | bens | Status | None | In Progress | |
Assigned to | None | bens | |||
2018-04-23 | bens | Summary | Fix segfault in spamming word completions | fix a segfault in the search for word completions | |
2018-04-23 | easyaspi314 | Attached File | - | Added crash.patch, #43988 |
Powered by Savane 3.13-f8d8.
Corresponding source code
Bug has been rereported as bug #53722. Thanks.
About the other warnings... If you have patches for some of them, please open a new issue.