GNU nano - Patches: patch #9215, Cleanups and fixes for...
You are not allowed to post comments on this tracker with your current authentication level.
patch #9215: Cleanups and fixes for reset_cursor()
Submitter: | David Lawrence Ramsey <dolorous> | ||
Submitted: | Mon 09 Jan 2017 05:26:16 PM UTC | ||
Priority: | 3 - Low | Status: | Done |
Privacy: | Public | Assigned to: | bens |
Open/Closed: | Closed | Release: | None |
Sun 26 Feb 2017 07:04:58 PM UTC, comment #5: |
David Lawrence Ramsey <dolorous> |
Sun 26 Feb 2017 04:37:03 PM UTC, comment #4: A change similar to yours has been pushed, 2e53ed29, but without changing any of the functionality, just improving the clarity. |
Benno Schulenberg <bens> |
Wed 11 Jan 2017 07:04:50 PM UTC, comment #3: Corrections to the bug description: it's display_buffer(), not load_buffer(), and display_buffer() also calls edit_refresh(), so if the buffer is an invalid state, that shouldn't be done either. |
David Lawrence Ramsey <dolorous> |
Wed 11 Jan 2017 06:26:44 PM UTC, comment #2: Okay. I've been using these changes for a while, and I'm pretty sure that overshoots of current_y are only handled by edit_redraw() and edit_refresh(), but you're right to be paranoid here.
|
David Lawrence Ramsey <dolorous> |
Wed 11 Jan 2017 11:42:45 AM UTC, comment #1: I don't think it is a good idea to /not/ set current_y when the calculated value for it is out of range. I am pretty sure that some of the current scrolling behavior depends on current_y overshooting the bottom of the window in order to move the cursor to the bottomline (after the screen has been repainted, not for this first call of reset_cursor()).
|
Benno Schulenberg <bens> |
Mon 09 Jan 2017 05:26:16 PM UTC, original submission:
The attached patch set does the following for reset_cursor():
|
David Lawrence Ramsey <dolorous> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 11 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2017-04-02 | bens | Open/Closed | Open | Closed | |
2017-02-26 | bens | Priority | 5 - Normal | 3 - Low | |
Status | None | Done | |||
Assigned to | None | bens | |||
2017-01-11 | dolorous | Attached File | - | Added reset_cursor-current_y-test.txt, #39436 | |
2017-01-09 | dolorous | Attached File | - | Added 0005-Tweaks-to-reset_cursor-part-5-Reduce-the-amount-of-d.patch, #39405 | |
Attached File | - | Added 0006-Tweaks-to-reset_cursor-part-6-Add-clarifying-comment.patch, #39406 | |||
2017-01-09 | dolorous | Attached File | - | Added 0001-Tweaks-to-reset_cursor-part-1-Make-sure-that-openfil.patch, #39401 | |
Attached File | - | Added 0002-Tweaks-to-reset_cursor-part-2-Improve-formatting.patch, #39402 | |||
Attached File | - | Added 0003-Tweaks-to-reset_cursor-part-3-Make-sure-that-openfil.patch, #39403 | |||
Attached File | - | Added 0004-Tweaks-to-reset_cursor-part-4-Simplify-handling-of-i.patch, #39404 |
Powered by Savane 3.13-caa5.
Corresponding source code
Good to know I could still contribute something. Thank you.