bugGNU Octave - Bugs: bug #62436, pkg build fails if no configure...

 
 

bug #62436: pkg build fails if no configure file exists

Submitter:  Orion Poplawski <opoplawski>
Submitted:  Wed 11 May 2022 03:08:26 AM UTC
   
 
Category:  Octave Function Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Regression
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * 7.1.0 Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Tue 05 Jul 2022 03:09:05 PM UTC, comment #7: 

No further comments for 2 weeks.  Marking bug as Fixed and closing report.

Rik <rik5>
Group administrator
Wed 25 May 2022 06:53:13 AM UTC, comment #6: 

That change looks good to me.

I pushed the patch to the stable branch here:
https://hg.savannah.gnu.org/hgweb/octave/rev/6e91c61f626f

Marking as ready for test.


Markus Mützel <mmuetzel>
Group administrator
Fri 13 May 2022 03:31:57 AM UTC, comment #5: 

Thanks.  That appears to resolve the issue.

Orion Poplawski <opoplawski>
Thu 12 May 2022 12:37:03 PM UTC, comment #4: 

Patch attached that checks for file before unlinking it.


(file #53190)

John Donoghue <lostbard>
Group Member
Thu 12 May 2022 12:22:09 PM UTC, comment #3: 

Ok - happens to me too if using the build command. The package itself using the install command.

John Donoghue <lostbard>
Group Member
Thu 12 May 2022 02:04:24 AM UTC, comment #2: 

I'm using version 3.1.3 from here: https://github.com/mpimd-csc/flexiblas

I'm seeing the same problem with io, odepkg, quaternion, and signal.  Build is done with:

Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.2mDNEI
+ umask 022
+ cd /home/orion/fedora/octave-flexiblas
+ CFLAGS='-O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-stro
ng -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m64  -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection'
+ export CFLAGS
+ CXXFLAGS='-O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-st
rong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m64  -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection'
+ export CXXFLAGS
+ FFLAGS='-O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-stro
ng -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m64  -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -I/usr/lib64/gfortran/modules'
+ export FFLAGS
+ FCFLAGS='-O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-str
ong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m64  -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -I/usr/lib64/gfortran/modules'
+ export FCFLAGS
+ LDFLAGS='-Wl,-z,relro -Wl,--as-needed  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -Wl,--build-id=sha1 -Wl,-dT,/home/orion/fedora/octave-flexiblas/flexiblas-octave/.package_n
ote-octave-flexiblas-3.1.3-1.fc37.x86_64.ld'
+ export LDFLAGS
+ LT_SYS_LIBRARY_PATH=/usr/lib64:
+ export LT_SYS_LIBRARY_PATH
+ CC=gcc
+ export CC
+ CXX=g++
+ export CXX
+ '[' -f /usr/lib/rpm/generate-rpm-note.sh ']'
+ /usr/lib/rpm/generate-rpm-note.sh octave-flexiblas 3.1.3-1.fc37 x86_64
+ cd flexiblas-octave
+ tar czf /var/tmp/flexiblas-3.1.3.tar.gz -C /home/orion/fedora/octave-flexiblas flexiblas-octave
+ mkdir -p /home/orion/fedora/octave-flexiblas/flexiblas-octave/build
+ octave -H -q --no-window-system --no-site-file --eval 'pkg build -verbose -nodeps /home/orion/fedora/octave-flexiblas/flexiblas-octave/build /var/tmp/flexiblas-3.1.3.tar.gz'

Orion Poplawski <opoplawski>
Wed 11 May 2022 12:02:55 PM UTC, comment #1: 

Where did you get the flexiblas package from?

Using https://csc.mpi-magdeburg.mpg.de/mpcsc/software/flexiblas/flexiblas-octave-3.0.4.tar.gz seemed to work for me.


However, you are right - it does look like the change in unlink in octave 7.1 to error in command form needs a change to build.m to handle the possible fail of configure not being there

John Donoghue <lostbard>
Group Member
Wed 11 May 2022 03:08:26 AM UTC, original submission:  

When trying to build the flexiblas package with octave 7.1 for Fedora:

make: Leaving directory '/home/orion/fedora/octave-flexiblas/flexiblas-octave/build/flexiblas-octave/src'

error: unlink: operation failed: No such file or directory
error: called from
    build at line 81 column 7
    pkg at line 720 column 7

Apparently it is trying to delete: /home/orion/fedora/octave-flexiblas/flexiblas-octave/build/flexiblas-octave/src/configure

but this file does not exist.  It seems like new behavior that unlink fails on non-existent files and many users of it do not handle that well.

Orion Poplawski <opoplawski>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #53190:  bug62436.patch added by lostbard (1KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by mmuetzel (Posted a comment)
  • -email is unavailable- added by lostbard (Posted a comment)
  • -email is unavailable- added by opoplawski (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-07-05 mmuetzel Open/ClosedOpen Closed
    2022-07-05 rik5 StatusReady For Test Fixed
    2022-05-25 mmuetzel StatusPatch Submitted Ready For Test
        Operating SystemGNU/Linux Any
    2022-05-12 lostbard Attached File- Added bug62436.patch, #53190
        StatusConfirmed Patch Submitted
    2022-05-12 lostbard StatusNone Confirmed

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code