bugGNU Octave - Bugs: bug #55933, Build errors for dev Octave in...

 
 

bug #55933: Build errors for dev Octave in mxe-octave due to dropped suppport for Sundials 2.7.0

Submitter:  Philip Nienhuis <philipnienhuis>
Submitted:  Sat 16 Mar 2019 12:35:22 PM UTC
   
 
Category:  Configuration and Build System Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Build Failure
Status:  Fixed Assigned to:  None
Originator Name:  Philip Nienhuis Open/Closed:  * Closed
Release:  * dev Operating System:  * Microsoft Windows
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Thu 21 Mar 2019 03:26:43 PM UTC, comment #15: 

Buildbots seem to be ok for all targets.

Closing as fixed.

Markus Mützel <mmuetzel>
Group administrator
Mon 18 Mar 2019 11:41:38 PM UTC, comment #14: 

Since the problem with configuring default Octave with Sundials 4.x has been fixed, I pushed the following modifeid changeset for mxe-octave:

https://hg.octave.org/mxe-octave/rev/0cbc51911dd0

It seems to work for me.  We'll see whether the buildbots approve.

John W. Eaton <jwe>
Group administrator
Mon 18 Mar 2019 07:09:21 PM UTC, comment #13: 

My intent was to fix the configure script so that building with Sundials 4.x would work without needing to set CPPFLAGS.  But the test for sundials_klu.h is failing because it includes <klu.h> but that fails if you only have <suitesparse/klu.h> in the default include path.  So the configure test probably can't just be a simple AC_CHECK_HEADER call on sundials_klu.h  If that fails, it needs to try compiling a program that does


#include <suitesparse/klu.h>
#include <sundials_klu.h>


since that's what we actually do in Octave.  I'll try to come up with a patch for that.  Then we should be able to drop the CPPFLAGS setting in your change.  Otherwise, I think your change for mxe-octave looks fine, so could you go ahead and push it?

Thanks!

John W. Eaton <jwe>
Group administrator
Mon 18 Mar 2019 06:44:21 PM UTC, comment #12: 

I filed bug #55950 for configure unable to detect sundials KLU support without passing custom -I options.

Up to those working on and testing mxe-octave if you want to patch this temporarily to include all features for testing on Windows, or if you want to wait until this is fixed in configure.

Mike Miller <mtmiller>
Group Member
Sun 17 Mar 2019 06:51:01 PM UTC, comment #11: 

Thanks, Mike. I think that finally did it.

Adding CPPFLAGS='-I$(HOST_INCDIR)/suitesparse' to the configure flags let's Octave pick up Sundials KLU:

hecking nvector/nvector_serial.h usability... yes
checking nvector/nvector_serial.h presence... yes
checking for nvector/nvector_serial.h... yes
checking for N_VNew_Serial in -lsundials_nvecserial... yes
checking ida/ida.h usability... yes
checking ida/ida.h presence... yes
checking for ida/ida.h... yes
checking for IDAInit in -lsundials_ida... yes
checking whether SUNDIALS IDA is configured with double precision realtype... yes
checking sunlinsol/sunlinsol_dense.h usability... yes
checking sunlinsol/sunlinsol_dense.h presence... yes
checking for sunlinsol/sunlinsol_dense.h... yes
checking whether SUNDIALS IDA includes the SUNLINSOL_DENSE linear solver... yes
checking sunlinsol/sunlinsol_klu.h usability... yes
checking sunlinsol/sunlinsol_klu.h presence... yes
checking for sunlinsol/sunlinsol_klu.h... yes
checking for SUNKLU in -lsundials_sunlinsolklu... yes
checking whether compiling a program that calls SUNKLU works... yes
checking for IDASetJacFn... yes
checking for IDASetLinearSolver... yes
checking for SUNLinSol_Dense... yes
checking for SUNLinSol_KLU... yes
checking ida/ida_direct.h usability... yes
checking ida/ida_direct.h presence... yes
checking for ida/ida_direct.h... yes
checking ida_direct.h usability... no
checking ida_direct.h presence... no
checking for ida_direct.h... no
checking for IDADlsSetJacFn... no
checking for IDADlsSetLinearSolver... no
checking for SUNDenseLinearSolver... yes
checking for SUNKLU... yes


The attached patch for MXE Octave should allow compiling Octave with ode15i and ode15s that support the sparse Jacobian feature for the default, stable and release targets.
Maybe pending a fix in default Octave that makes the last change redundant.

(file #46566)

Markus Mützel <mmuetzel>
Group administrator
Sun 17 Mar 2019 06:31:26 PM UTC, comment #10: 

You can certainly test adding CPPFLAGS to the Octave build and see if it processes that include file right. But I think this is yet another bug on the default branch, with sundials 4 my understanding was the user would not have to pass any additional options and it will just work, but this may still be a work in progress.

Mike Miller <mtmiller>
Group Member
Sun 17 Mar 2019 06:23:23 PM UTC, comment #9: 

The configure test fails with this error:

In file included from conftest.c:475:0:
/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/usr/x86_64-w64-mingw32/include/sunlinsol/sunlinsol_klu.h:34:10: fatal error: klu.h: No such file or directory
 #include <klu.h>
          ^~~~~~~
compilation terminated.


klu.h is in  ~/Documents/Repositories/Octave/mxe-octave-3/usr/x86_64-w64-mingw32/include/suitesparse

Do we have to add that to CPPFLAGS?

KLU_INCLUDE_DIR pointed to that directory when Sundials IDA was built:

cd '/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/tmp-sundials-ida/sundials-4.1.0.build' && cmake -DEXAMPLES_ENABLE=OFF -DKLU_ENABLE=ON -DKLU_INCLUDE_DIR=/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/usr/x86_64-w64-mingw32/include/suitesparse -DKLU_LIBRARY_DIR=/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/usr/x86_64-w64-mingw32/lib -DSUITESPARSECONFIG_LIBRARY=/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/usr/x86_64-w64-mingw32/lib/libsuitesparseconfig.dll.a -DCMAKE_TOOLCHAIN_FILE='/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/usr/x86_64-w64-mingw32/share/cmake/mxe-conf.cmake' -DBUILD_ARKODE=OFF -DBUILD_CVODE=OFF -DBUILD_CVODES=OFF -DBUILD_IDA=ON -DBUILD_IDAS=OFF -DBUILD_KINSOL=OFF -DBUILD_CPODES=OFF '/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/tmp-sundials-ida/sundials-4.1.0'


Markus Mützel <mmuetzel>
Group administrator
Sun 17 Mar 2019 06:00:06 PM UTC, comment #8: 

That's better. I don't know much about this configuration step, but I think all that may be missing is an include option, not completely sure. I have only tested with sundials 2.x and 3.1, I haven't gotten around to building and trying sundials 4 yet myself. I thought that sundials 4 had a fix that would allow configure to work without adding -I/usr/include/suitesparse or other custom -I options. You could look in config.log to see what is failing about the sunlinsol/sunlinsol_klu.h include file.

Mike Miller <mtmiller>
Group Member
Sun 17 Mar 2019 05:37:26 PM UTC, comment #7: 

I forgot to commit the changes for the stable and release-octave.mk files before I made the patch. So here an updated patch with these included.

The stable target builds successfully with these changes (I assume that release would as well).

However for the default-octave target, I see the following in the logs:

checking for N_VNew_Serial in -lsundials_nvecserial... yes
checking ida/ida.h usability... yes
checking ida/ida.h presence... yes
checking for ida/ida.h... yes
checking for IDAInit in -lsundials_ida... yes
checking whether SUNDIALS IDA is configured with double precision realtype... yes
checking sunlinsol/sunlinsol_dense.h usability... yes
checking sunlinsol/sunlinsol_dense.h presence... yes
checking for sunlinsol/sunlinsol_dense.h... yes
checking whether SUNDIALS IDA includes the SUNLINSOL_DENSE linear solver... yes
checking sunlinsol/sunlinsol_klu.h usability... no
checking sunlinsol/sunlinsol_klu.h presence... no
checking for sunlinsol/sunlinsol_klu.h... no
configure: WARNING: SUNDIALS IDA library not configured with SUNLINSOL_KLU or sunlinksol_klu.h is not usable; ode15i and ode15s will not support the sparse Jacobian feature
checking for IDASetJacFn... yes
checking for IDASetLinearSolver... yes
checking for SUNLinSol_Dense... yes
checking for SUNLinSol_KLU... no
checking ida/ida_direct.h usability... yes
checking ida/ida_direct.h presence... yes
checking for ida/ida_direct.h... yes
checking ida_direct.h usability... no
checking ida_direct.h presence... no
checking for ida_direct.h... no
checking for IDADlsSetJacFn... no
checking for IDADlsSetLinearSolver... no
checking for SUNDenseLinearSolver... yes
checking for SUNKLU... no


sunlinsol_klu.h is present in ~/Documents/Repositories/Octave/mxe-octave-3/usr/x86_64-w64-mingw32/include/sunlinsol

Octave is configured with:

'/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/tmp-default-octave/octave-6.0.0/configure' CPPFLAGS='-I/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/usr/x86_64-w64-mingw32/include' LDFLAGS='-L/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/usr/x86_64-w64-mingw32/lib' --host='x86_64-w64-mingw32' --build='x86_64-pc-linux-gnu' --prefix=''/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/usr/x86_64-w64-mingw32'' --disable-silent-rules --enable-install-build-logs FLTK_CONFIG='/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/usr/bin/x86_64-w64-mingw32-fltk-config' gl_cv_func_gettimeofday_clobber=no gl_cv_func_tzset_clobber=no --with-blas="-lblas -lxerbla" --enable-64 ax_blas_f77_func_ok=yes ax_blas_integer_size=4 octave_cv_sizeof_fortran_integer=4 --with-java-includedir="/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/usr/x86_64-w64-mingw32/include/java" --disable-jit  MOC_QTVER='/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/usr/bin/x86_64-w64-mingw32-moc' UIC_QTVER='/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/usr/bin/x86_64-w64-mingw32-uic' RCC_QTVER='/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/usr/bin/x86_64-w64-mingw32-rcc' LRELEASE_QTVER='/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/usr/bin/x86_64-w64-mingw32-lrelease' octave_cv_lib_qscintilla="-lqscintilla2_qt5" LDFLAGS='-Wl,-rpath-link,/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/usr/x86_64-w64-mingw32/lib -L/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/usr/x86_64-w64-mingw32/lib -L/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/usr/x86_64-w64-mingw32/qt5/lib' --with-x=no --enable-cross-tools PKG_CONFIG=''/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/usr/bin/pkg-config'' PKG_CONFIG_PATH="/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/usr/x86_64-w64-mingw32/qt5/lib/pkgconfig:/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/usr/x86_64-w64-mingw32/lib/pkgconfig"


CPPFLAGS seems to be correctly pointing to that directory.
Do I have to change some configure flags to get this to work?


In the build logs for sundials-ida 4.10, I see this:

-- Looking for KLU libraries...
-- Checking if KLU works... OK
-- Added NVECTOR_SERIAL module
-- Added SUNMATRIX_BAND module
-- Added SUNMATRIX_DENSE module
-- Added SUNMATRIX_SPARSE module
-- Added SUNLINSOL_BAND module
-- Added SUNLINSOL_DENSE module
-- Added SUNLINSOL_PCG module
-- Added SUNLINSOL_SPBCGS module
-- Added SUNLINSOL_SPFGMR module
-- Added SUNLINSOL_SPGMR module
-- Added SUNLINSOL_SPTFQMR module
-- Added SUNLINSOL_KLU module
-- Added SUNNONLINSOL_NEWTON module
-- Added SUNNONLINSOL_FIXEDPOINT module
-- Added IDA module
-- Configuring done


So I am assuming that sundials is configured with KLU.


(file #46565)

Markus Mützel <mmuetzel>
Group administrator
Sat 16 Mar 2019 08:24:39 PM UTC, comment #6: 

I reported bug #55937 after confirming 'make' fails with sundials 2.5 and 2.7.

Mike Miller <mtmiller>
Group Member
Sat 16 Mar 2019 06:26:28 PM UTC, comment #5: 

The attached patch might allow using sundials 2.7.0 with release and stable and sundials 4.1.0 with default.
It is still un-tested.

(file #46560)

Markus Mützel <mmuetzel>
Group administrator
Sat 16 Mar 2019 06:00:07 PM UTC, comment #4: 

No, that's a separate bug. I haven't tried that yet, but can probably reproduce on Ubuntu, I will file another bug about that, this bug can be about choosing which sundials or both versions to support in mxe-octave.

Mike Miller <mtmiller>
Group Member
Sat 16 Mar 2019 05:40:07 PM UTC, comment #3: 

MXE builds (with sundials 2.7.0) for default are failing with the error:

/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/tmp-default-octave/octave-6.0.0/libinterp/dldfcn/__ode15__.cc:264:39: error: 'SUNMatrix' has not been declared
               N_Vector yyp, N_Vector, SUNMatrix JJ, void *user_data,
                                       ^~~~~~~~~
/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/tmp-default-octave/octave-6.0.0/libinterp/dldfcn/__ode15__.cc:274:49: error: 'SUNMatrix' has not been declared
                    N_Vector& yy, N_Vector& yyp, SUNMatrix& JJ);
                                                 ^~~~~~~~~
/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/tmp-default-octave/octave-6.0.0/libinterp/dldfcn/__ode15__.cc:353:5: error: 'SUNMatrix' does not name a type; did you mean 'Matrix'?
     SUNMatrix sunJacMatrix;
     ^~~~~~~~~
     Matrix
/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/tmp-default-octave/octave-6.0.0/libinterp/dldfcn/__ode15__.cc:354:5: error: 'SUNLinearSolver' does not name a type
     SUNLinearSolver sunLinearSolver;
     ^~~~~~~~~~~~~~~
/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/tmp-default-octave/octave-6.0.0/libinterp/dldfcn/__ode15__.cc: In constructor 'octave::IDA::IDA()':
/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/tmp-default-octave/octave-6.0.0/libinterp/dldfcn/__ode15__.cc:169:9: error: class 'octave::IDA' does not have any field named 'sunJacMatrix'
         sunJacMatrix (nullptr), sunLinearSolver (nullptr)
         ^~~~~~~~~~~~
/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/tmp-default-octave/octave-6.0.0/libinterp/dldfcn/__ode15__.cc:169:33: error: class 'octave::IDA' does not have any field named 'sunLinearSolver'
         sunJacMatrix (nullptr), sunLinearSolver (nullptr)
                                 ^~~~~~~~~~~~~~~
/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/tmp-default-octave/octave-6.0.0/libinterp/dldfcn/__ode15__.cc: In constructor 'octave::IDA::IDA(realtype, ColumnVector, ColumnVector, const octave_value&, octave::IDA::DAERHSFuncIDA)':
/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/tmp-default-octave/octave-6.0.0/libinterp/dldfcn/__ode15__.cc:180:9: error: class 'octave::IDA' does not have any field named 'sunJacMatrix'
         sunJacMatrix (nullptr), sunLinearSolver (nullptr)
         ^~~~~~~~~~~~
/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/tmp-default-octave/octave-6.0.0/libinterp/dldfcn/__ode15__.cc:180:33: error: class 'octave::IDA' does not have any field named 'sunLinearSolver'
         sunJacMatrix (nullptr), sunLinearSolver (nullptr)
                                 ^~~~~~~~~~~~~~~
/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/tmp-default-octave/octave-6.0.0/libinterp/dldfcn/__ode15__.cc: In destructor 'octave::IDA::~IDA()':
/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/tmp-default-octave/octave-6.0.0/libinterp/dldfcn/__ode15__.cc:187:21: error: 'sunLinearSolver' was not declared in this scope
       SUNLinSolFree(sunLinearSolver);
                     ^~~~~~~~~~~~~~~
/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/tmp-default-octave/octave-6.0.0/libinterp/dldfcn/__ode15__.cc:187:7: error: 'SUNLinSolFree' was not declared in this scope
       SUNLinSolFree(sunLinearSolver);
       ^~~~~~~~~~~~~
/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/tmp-default-octave/octave-6.0.0/libinterp/dldfcn/__ode15__.cc:188:21: error: 'sunJacMatrix' was not declared in this scope
       SUNMatDestroy(sunJacMatrix);
                     ^~~~~~~~~~~~
/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/tmp-default-octave/octave-6.0.0/libinterp/dldfcn/__ode15__.cc:188:21: note: suggested alternative: 'DiagMatrix'
       SUNMatDestroy(sunJacMatrix);
                     ^~~~~~~~~~~~
                     DiagMatrix
/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/tmp-default-octave/octave-6.0.0/libinterp/dldfcn/__ode15__.cc:188:7: error: 'SUNMatDestroy' was not declared in this scope
       SUNMatDestroy(sunJacMatrix);
       ^~~~~~~~~~~~~
/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/tmp-default-octave/octave-6.0.0/libinterp/dldfcn/__ode15__.cc:188:7: note: suggested alternative: 'N_VDestroy'
       SUNMatDestroy(sunJacMatrix);
       ^~~~~~~~~~~~~
       N_VDestroy
/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/tmp-default-octave/octave-6.0.0/libinterp/dldfcn/__ode15__.cc: In member function 'void octave::IDA::set_up(const ColumnVector&)':
/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/tmp-default-octave/octave-6.0.0/libinterp/dldfcn/__ode15__.cc:418:9: error: 'sunJacMatrix' was not declared in this scope
         sunJacMatrix = SUNDenseMatrix (num, num);
         ^~~~~~~~~~~~
/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/tmp-default-octave/octave-6.0.0/libinterp/dldfcn/__ode15__.cc:418:9: note: suggested alternative: 'DiagMatrix'
         sunJacMatrix = SUNDenseMatrix (num, num);
         ^~~~~~~~~~~~
         DiagMatrix
/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/tmp-default-octave/octave-6.0.0/libinterp/dldfcn/__ode15__.cc:418:24: error: 'SUNDenseMatrix' was not declared in this scope
         sunJacMatrix = SUNDenseMatrix (num, num);
                        ^~~~~~~~~~~~~~
/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/tmp-default-octave/octave-6.0.0/libinterp/dldfcn/__ode15__.cc:418:24: note: suggested alternative: 'SparseMatrix'
         sunJacMatrix = SUNDenseMatrix (num, num);
                        ^~~~~~~~~~~~~~
                        SparseMatrix
/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/tmp-default-octave/octave-6.0.0/libinterp/dldfcn/__ode15__.cc:422:9: error: 'sunLinearSolver' was not declared in this scope
         sunLinearSolver = SUNLinSol_Dense (yy, sunJacMatrix);
         ^~~~~~~~~~~~~~~
/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/tmp-default-octave/octave-6.0.0/libinterp/dldfcn/__ode15__.cc:422:27: error: 'SUNLinSol_Dense' was not declared in this scope
         sunLinearSolver = SUNLinSol_Dense (yy, sunJacMatrix);
                           ^~~~~~~~~~~~~~~
/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/tmp-default-octave/octave-6.0.0/libinterp/dldfcn/__ode15__.cc:426:13: error: 'IDASetLinearSolver' was not declared in this scope
         if (IDASetLinearSolver (mem, sunLinearSolver, sunJacMatrix))
             ^~~~~~~~~~~~~~~~~~
/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/tmp-default-octave/octave-6.0.0/libinterp/dldfcn/__ode15__.cc:426:13: note: suggested alternative: 'IDAGetLastOrder'
         if (IDASetLinearSolver (mem, sunLinearSolver, sunJacMatrix))
             ^~~~~~~~~~~~~~~~~~
             IDAGetLastOrder
/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/tmp-default-octave/octave-6.0.0/libinterp/dldfcn/__ode15__.cc:429:24: error: 'IDASetJacFn' was not declared in this scope
         if (havejac && IDASetJacFn (mem, IDA::jacdense) != 0)
                        ^~~~~~~~~~~
/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/tmp-default-octave/octave-6.0.0/libinterp/dldfcn/__ode15__.cc:429:24: note: suggested alternative: 'IDASetId'
         if (havejac && IDASetJacFn (mem, IDA::jacdense) != 0)
                        ^~~~~~~~~~~
                        IDASetId
/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/tmp-default-octave/octave-6.0.0/libinterp/dldfcn/__ode15__.cc: At global scope:
/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/tmp-default-octave/octave-6.0.0/libinterp/dldfcn/__ode15__.cc:437:52: error: 'SUNMatrix' has not been declared
                       N_Vector& yy, N_Vector& yyp, SUNMatrix& JJ)
                                                    ^~~~~~~~~
/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/tmp-default-octave/octave-6.0.0/libinterp/dldfcn/__ode15__.cc: In member function 'void octave::IDA::jacdense_impl(realtype, realtype, _generic_N_Vector*&, _generic_N_Vector*&, int&)':
/home/osboxes/Documents/Repositories/Octave/mxe-octave-3/tmp-default-octave/octave-6.0.0/libinterp/dldfcn/__ode15__.cc:457:7: error: 'SUNDenseMatrix_Data' was not declared in this scope
       SUNDenseMatrix_Data(JJ));
       ^~~~~~~~~~~~~~~~~~~
make[5]: *** [Makefile:19254: libinterp/dldfcn/__ode15___la-__ode15__.lo] Error 1


Is it expected that the compilation fails if a version of sundials is found that is too old?
"HAVE_SUNDIALS" is still defined. Is it possible to detect that the installed version of sundials is too old and not use it at all?
I hope this is the relevant part of the config output:

checking for N_VNew_Serial in -lsundials_nvecserial... yes
checking ida/ida.h usability... yes
checking ida/ida.h presence... yes
checking for ida/ida.h... yes
checking for IDAInit in -lsundials_ida... yes
checking whether SUNDIALS IDA is configured with double precision realtype... yes
checking sunlinsol/sunlinsol_dense.h usability... no
checking sunlinsol/sunlinsol_dense.h presence... no
checking for sunlinsol/sunlinsol_dense.h... no
checking whether SUNDIALS IDA includes the SUNLINSOL_DENSE linear solver... yes
checking sunlinsol/sunlinsol_klu.h usability... no
checking sunlinsol/sunlinsol_klu.h presence... no
checking for sunlinsol/sunlinsol_klu.h... no
configure: WARNING: SUNDIALS IDA library not configured with SUNLINSOL_KLU or sunlinksol_klu.h is not usable; ode15i and ode15s will not support the sparse Jacobian feature
checking for IDASetJacFn... no
checking for IDASetLinearSolver... no
checking for SUNLinSol_Dense... no
checking for SUNLinSol_KLU... no
checking ida/ida_direct.h usability... yes
checking ida/ida_direct.h presence... yes
checking for ida/ida_direct.h... yes
checking ida_direct.h usability... no
checking ida_direct.h presence... no
checking for ida_direct.h... no
checking for IDADlsSetJacFn... no
checking for IDADlsSetLinearSolver... no
checking for SUNDenseLinearSolver... no
checking for SUNKLU... no


Markus Mützel <mmuetzel>
Group administrator
Sat 16 Mar 2019 04:49:57 PM UTC, comment #2: 

There is no one sundials version that will work with both stable Octave 5 and default Octave 6. Stable still works with 2.7, default now only works with the new API in 3-4.x.

Mike Miller <mtmiller>
Group Member
Sat 16 Mar 2019 01:53:28 PM UTC, comment #1: 

Do we still need sundials 2.7.0 for the octave-release?
Is there a sundials version that should work with release and default?

Markus Mützel <mmuetzel>
Group administrator
Sat 16 Mar 2019 12:35:22 PM UTC, original submission:  

As of the fixes for bug #52475 dev Octave won't build anymore with
Sundials-2.7.0 that ATM is included in mxe-octave.
So please upgrade Sundials in mxe-octave.

Philip Nienhuis <philipnienhuis>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #46566:  bug55933_sundials_410_v3.patch added by mmuetzel (8KiB - application/octet-stream)
file #46565:  bug55933_sundials_410_v2.patch added by mmuetzel (7KiB - application/octet-stream)
file #46560:  bug55933_sundials_410.patch added by mmuetzel (5KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by mmuetzel (Posted a comment)
  • -email is unavailable- added by philipnienhuis (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-03-21 mmuetzel StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2019-03-18 jwe StatusPatch Submitted Ready For Test
    2019-03-17 mmuetzel StatusNone Patch Submitted
    2019-03-17 mmuetzel Attached File- Added bug55933_sundials_410_v3.patch, #46566
    2019-03-17 mmuetzel Attached File- Added bug55933_sundials_410_v2.patch, #46565
    2019-03-16 mmuetzel Attached File- Added bug55933_sundials_410.patch, #46560

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code