bugGNU Octave - Bugs: bug #57540, new failing test in bp-table.cc-tst

 
 

bug #57540: new failing test in bp-table.cc-tst

Submitter:  Hartmut <hardy>
Submitted:  Sat 04 Jan 2020 10:17:04 PM UTC
   
 
Category:  Test Suite Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Unexpected Error or Warning
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Post a Comment

Add a New Comment Rich Markup
   

Discussion

Mon 06 Jan 2020 04:28:23 PM UTC, comment #3: 

Pushed commit on the default branch

https://hg.savann ... /rev/8df92c17bb5c

Mike Miller <mtmiller>
Group Member
Sun 05 Jan 2020 11:56:56 PM UTC, comment #2: 

I reviewed the patch and it is the correct fix.  I also verified that the two test failures go away when the patch is applied.

Rik <rik5>
Group administrator
Sun 05 Jan 2020 01:21:52 AM UTC, comment #1: 

Confirmed. The numbers being compared are line numbers, and ls.m recently had 2 comment lines deleted.

I think the attached patch restores the original intent of this test.

(file #48164)

Mike Miller <mtmiller>
Group Member
Sat 04 Jan 2020 10:17:04 PM UTC, original submission:  

I have just compiled dev Octave (hg id: f658d41003e4), run "make install" and then run "make test" under linux. In addition to two failing tests in publish.tst (they are already somwhere in Savannah, I think), I have seen one newly failing test in pb-table.cc-tst:


>>>>> processing /home/hartmut-nobackup/octave-repo/libinterp/parse-tree/bp-table.cc-tst
***** test
 dbclear all;   # Clear out breakpoints before test
 dbstop help;
 dbstop in ls;
 dbstop help at 100;
 dbstop in ls 100;    ## 100 is a comment; code line is at 103
 dbstop help 201 if a==5;
 dbstop if error Octave:undefined-function;
 s = dbstatus;
 dbclear all;
 assert ({s.bkpt(:).name}, {"help", "help", "help>do_contents", "ls", "ls"});
 assert ([s.bkpt(:).line], [48, 100, 201, 58, 103]);
 assert (s.errs, {"Octave:undefined-function"});
!!!!! test failed
ASSERT errors for:  assert ([s.bkpt(:).line],[48, 100, 201, 58, 103])

  Location  |  Observed  |  Expected  |  Reason
    (4)           56           58        Abs err 2 exceeds tol 0 by 2
    (5)          101          103        Abs err 2 exceeds tol 0 by 2


I am not sure about the meaning of this test function, but thought I'd report it anyways. I haven't found any bug report in Savannah yet, when searching for "bp-table.cc-tst".

Hartmut <hardy>

 

Attached Files

Attached Files
file #48164:  bug-57540.patch added by mtmiller (1.2KiB - text/x-patch)

(Note: upload size limit is set to 4.0MiB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

 

Dependencies

This item does not depend on any other items.

No items depend on this one.

 

Mail Notification Carbon-Copy List

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by hardy (Submitted the item)
  •  

    Votes

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    History

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-01-06 mtmiller StatusPatch Reviewed Fixed
        Open/ClosedOpen Closed
    2020-01-05 rik5 CategoryNone Test Suite
        StatusPatch Submitted Patch Reviewed
    2020-01-05 mtmiller Attached File- Added bug-57540.patch, #48164
        StatusNone Patch Submitted

    Back to the top

    Powered by Savane 3.16-11ef.
    Corresponding source code