GNU nano - Bugs: bug #65394, invalid read in...
You are not allowed to post comments on this tracker with your current authentication level.
bug #65394: invalid read in snip_last_keystroke() when typing M-: twice fast
Submitter: | correctmost <correctmost> | ||
Submitted: | Sat 02 Mar 2024 01:23:06 AM UTC | ||
Severity: | 3 - Normal | Status: | Fixed |
Assigned to: | bens | Open/Closed: | Open |
Fri 22 Mar 2024 03:41:11 PM UTC, comment #4: |
Benno Schulenberg <bens> |
Sun 03 Mar 2024 10:09:54 AM UTC, comment #3: Fixed in git, commit 191cf671, by moving the recording of keystrokes in the macrobuffer to its proper spot: the routine that reads a keystroke from nano's own keystroke buffer.
|
Benno Schulenberg <bens> |
Sat 02 Mar 2024 11:29:04 AM UTC, comment #2: Ah. When the second M-: arrives before the first one is processed (that is: the first one is still in nano's keystroke buffer), then 'recording' is still false and the second M-: will not be stored in the macro buffer. But when the second M-: is processed, then it expects its corresponding keystroke to be in the macro buffer. :/
|
Benno Schulenberg <bens> |
Sat 02 Mar 2024 11:09:32 AM UTC, comment #1: I don't have a remote machine with valgrind installed and can't be bothered to set up a virtual machine, but... I can reliably make nano (inside valgrind) crash by quickly typing M-: twice while valgrind+nano is starting up.
|
Benno Schulenberg <bens> |
Sat 02 Mar 2024 01:23:06 AM UTC, original submission:
I can reliably reproduce the following bug when I ssh into a test VM using mate-terminal or xfce4-terminal. I cannot reproduce the bug inside the test VM itself (even though the bug was first discovered via xdotool).
|
correctmost <correctmost> |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 5 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2024-03-03 | bens | Status | In Progress | Fixed | |
2024-03-02 | bens | Status | None | In Progress | |
Summary | invalid read in snip_last_keystroke() | invalid read in snip_last_keystroke() when typing M-: twice fast | |||
2024-03-02 | bens | Assigned to | None | bens | |
Summary | invalid read in snip_last_keystroke | invalid read in snip_last_keystroke() |
Powered by Savane 3.13-02a9.
Corresponding source code
Commit 91cf671 caused a major regression (bug #65507), so it was reverted.
The invalid read has been prevented in a simpler way by commit 3fb8efc8, by simply checking that 'macro_length' does not go through the floor.