bugGNU troff - Bugs: bug #61371, [PATCH] [tbl] use term...

 
 

bug #61371: [PATCH] [tbl] use term "decimal separator" instead of "decimal point" and "dot"

Submitted by:  Bjarni Ingi Gislason <bjarniig>
Submitted on:  Sat 23 Oct 2021 06:54:37 PM UTC
 
Category:  Preprocessor tbl Severity:  2 - Minor
Item Group:  Documentation Status:  Fixed
Privacy:  Public Assigned to:  gbranden
Open/Closed:  Closed Planned Release:  1.23.0
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       No canned response available

 

( Jump to the original submission )

Tue 09 Nov 2021 07:40:08 PM UTC, comment #12: 

comment #8:

> I see now the defect, the space at the beginning of unchanged lines
> is missing.


This turned out to be a savannah bug, which has now been fixed (http://savannah.nongnu.org/support/?110562).  I've looked at other groff bug reports with patches inside "verbatim" tags that were rendered wrongly before, and they look correct now too.

Dave <barx>
Project Member
Mon 08 Nov 2021 12:39:33 PM UTC, comment #11: 

comment #10:

> ...
> Keith's claim that "decimal separator" is "invalid terminology" is
> contradicted by Wikipedia's extensive, and extensively annotated, entry for the term,
> ...

Wikipedia is not authoritative.  Besides, the documentation in question is in the the English language, so English-specific terminology is appropriate.

Neither the Oxford Dictionary of UK English, (formerly the Oxford Dictionary of World English, and AFAIK, authoritative throughout the English-speaking world, outside the sphere of influence of the USA), nor Merriam-Webster, (authoritative in the US English-speaking world), offers any definition for the term "decimal separator"; both define "decimal point", (with a more comprehensive definition in Merriam-Webster).

POSIX.1-2017 consistently uses the "decimal point" terminology, (with "separator" only applied to thousands digit grouping).

Nonetheless, if you wish to engender a impression of utter technical ineptitude, by all means adopt this asinine change in terminology ... I really couldn't care less, any more.

Keith Marshall <keithmarshall>
Project Member
Sun 07 Nov 2021 06:34:26 AM UTC, comment #10: 

This change has been disputed: http://lists.gnu.org/r/groff/2021-11/msg00010.html

I don't know whose wording, Bjarni's or Keith's, is more correct here, and no one else on the list has offered an opinion.  However, Keith's claim that "decimal separator" is "invalid terminology" is contradicted by Wikipedia's extensive, and extensively annotated, entry for the term, which also says that "radix point" is the more general term used when bases other than 10 are under consideration.

Dave <barx>
Project Member
Mon 01 Nov 2021 01:21:39 PM UTC, comment #9: 

commit a0ec5ffd258b9f54daa46b88471ec837e8213ad1
Author: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
Date:   Sun Oct 31 00:42:09 2021 +0000

    tbl(1): Say decimal "separator", not "point".

    Fixes <https://savannah.gnu.org/bugs/index.php?61371>.

G. Branden Robinson <gbranden>
Project Administrator
Sun 31 Oct 2021 11:07:30 PM UTC, comment #8: 

I see now the defect, the space at the beginning of unchanged lines  is missing.  Patch is in the attachment.

(file #52178)

Bjarni Ingi Gislason <bjarniig>
Sun 31 Oct 2021 03:23:05 PM UTC, comment #7: 

  Is there a difference between my master branch and yours?

md5sum is

c4e88f3e7cbe5edbbf27d55183de22ca  tbl.1.man

wc shows

 1415  4544 26902 tbl.1.man

Bjarni Ingi Gislason <bjarniig>
Sun 31 Oct 2021 08:16:21 AM UTC, comment #6: 

I'm having to manually apply this.  :-/

$ head src/preproc/tbl/tbl.1.man
'\" t
.TH @g@tbl @MAN1EXT@ "@MDATE@" "groff @VERSION@"
.SH Name
@g@tbl \- format tables in groff documents
.
.
.\" Bernd Warken <groff-bernd.warken-72@web.de> added simple examples.
.
.\" ====================================================================
.\" Legal Terms
$ patch --dry-run -p1 <bjarni.diff
checking file src/preproc/tbl/tbl.1.man
patch: **** malformed patch at line 5: centered,

G. Branden Robinson <gbranden>
Project Administrator
Sun 31 Oct 2021 06:56:37 AM UTC, comment #5: 

Patch updated.

Dave <barx>
Project Member
Sun 31 Oct 2021 12:42:09 AM UTC, comment #4: 

diff -dpru --unidirectional-new-file groff/src/preproc/tbl/tbl.1.man new-groff/src/preproc/tbl/tbl.1.man
--- groff/src/preproc/tbl/tbl.1.man        2021-10-31 00:03:10.000000000 +0000
+++ new-groff/src/preproc/tbl/tbl.1.man        2021-10-31 00:10:16.000000000 +0000
@@ -157,7 +157,7 @@ Each cell in a column is classified by b
 centered,
 left-aligned,
 numeric
-(aligned to a decimal point),
+(aligned to a decimal separator),
 and so on.
 .
 This specification can have several lines,
@@ -214,7 +214,7 @@ extension).
 .
 .TP
 .BI decimalpoint( c )
-Set the character to be recognized as the decimal point in numeric
+Set the character to be recognized as the decimal separator in numeric
 columns
 (GNU
 .I tbl \" exception
@@ -417,10 +417,11 @@ Numerically justify item in the column;
 that is,
 align columns of numbers vertically at the units place.
 .
-If there are one or more dots adjacent to a digit,
+If there are one or more decimal separators adjacent to a digit,
 use the rightmost one for vertical alignment.
 .
-If there is no dot, use the rightmost digit for vertical alignment;
+If there is no decimal separator,
+use the rightmost digit for vertical alignment;
 otherwise, center the item within the column.
 .
 Alignment can be forced to a certain position using \[oq]\[rs]&\[cq];
@@ -1141,16 +1142,16 @@ sees the input earlier than
 .IR \%@g@troff .
 .
 For example,
-number formatting with vertically aligned decimal points fails if those
-numbers are passed on as macro parameters because decimal point
-alignment is handled by
+number formatting with vertically aligned decimal separators fails
+if those numbers are passed on as macro parameters
+because decimal separator alignment is handled by
 .I \%@g@tbl
 itself:
 it only sees
 .BR \[rs]$1 ,
 .BR \[rs]$2 ,
 etc.,
-and therefore can't recognize the decimal point.
+and therefore can't recognize the decimal separator.
 .
 .
 .\" ====================================================================

Bjarni Ingi Gislason <bjarniig>
Thu 28 Oct 2021 04:44:49 AM UTC, comment #3: 

Awaiting updated patch.

G. Branden Robinson <gbranden>
Project Administrator
Mon 25 Oct 2021 04:48:58 AM UTC, comment #2: 

As an aid to whoever evaluates/applies this patch, can you post a corrected version that contains only the intended changes?

Dave <barx>
Project Member
Sat 23 Oct 2021 06:57:36 PM UTC, comment #1: 

  The patch for tmac/an.tmac is intended for another report.

Bjarni Ingi Gislason <bjarniig>
Sat 23 Oct 2021 06:54:37 PM UTC, original submission:  

From e341431382850a0be5770e4c624aafe87130310d Mon Sep 17 00:00:00 2001
From: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
Date: Sat, 23 Oct 2021 18:45:59 +0000
Subject: [PATCH] [tbl]: tbl.1.man: use a neutral wording "decimal separator"
 in place of English specific "decimal point" and "dot"

tbl.1.man: use a neutral wording "decimal separator" in place of
English specific "decimal point" and "dot".

Signed-off-by: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
---
 src/preproc/tbl/tbl.1.man | 14 +++++++-------
 tmac/an.tmac              |  3 +++
 2 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/src/preproc/tbl/tbl.1.man b/src/preproc/tbl/tbl.1.man
index 297951c1..d1e82ed1 100644
--- a/src/preproc/tbl/tbl.1.man
+++ b/src/preproc/tbl/tbl.1.man
@@ -157,7 +157,7 @@ Each cell in a column is classified by being
 centered,
 left-aligned,
 numeric
-(aligned to a decimal point),
+(aligned to a decimal separator),
 and so on.
 .
 This specification can have several lines,
@@ -214,7 +214,7 @@ extension).
 .
 .TP
 .BI decimalpoint( c )
-Set the character to be recognized as the decimal point in numeric
+Set the character to be recognized as the decimal separator in numeric
 columns
 (GNU
 .I tbl \" exception
@@ -417,10 +417,10 @@ Numerically justify item in the column;
 that is,
 align columns of numbers vertically at the units place.
 .
-If there are one or more dots adjacent to a digit,
+If there are one or more decimal separators adjacent to a digit,
 use the rightmost one for vertical alignment.
 .
-If there is no dot, use the rightmost digit for vertical alignment;
+If there is no decimal separator, use the rightmost digit for vertical alignment;
 otherwise, center the item within the column.
 .
 Alignment can be forced to a certain position using \[oq]\[rs]&\[cq];
@@ -1141,8 +1141,8 @@ sees the input earlier than
 .IR \%@g@troff .
 .
 For example,
-number formatting with vertically aligned decimal points fails if those
-numbers are passed on as macro parameters because decimal point
+number formatting with vertically aligned decimal separators fails if those
+numbers are passed on as macro parameters because decimal separator
 alignment is handled by
 .I \%@g@tbl
 itself:
@@ -1150,7 +1150,7 @@ it only sees
 .BR \[rs]$1 ,
 .BR \[rs]$2 ,
 etc.,
-and therefore can't recognize the decimal point.
+and therefore can't recognize the decimal separator.
 .
 .
 .\" ====================================================================
diff --git a/tmac/an.tmac b/tmac/an.tmac
index 2b72640b..07580c98 100644
--- a/tmac/an.tmac
+++ b/tmac/an.tmac
@@ -880,6 +880,9 @@
 .
 .\" End table.
 .de1 TE
+.  if \\n[.ll]<\\n[TW] \{\
+.    tm line nr.\& \\n[.c], line length is \\n[.ll]u and width of table is \\n[TW]u
+.  \}
 .  if n \{\
 .    pl \\n[an-cur-page-length]u
 .  \}
--
2.33.0

Bjarni Ingi Gislason <bjarniig>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #52178:  tbl.1.man.diff.txt added by bjarniig (2KiB - text/plain - patch for tbl.1.man project groff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by keithmarshall (Posted a comment)
  • -email is unavailable- added by barx (Posted a comment)
  • -email is unavailable- added by barx
  • -email is unavailable- added by gbranden (Posted a comment)
  • -email is unavailable- added by bjarniig (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

     

     

     

    Follow 15 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-03-05 gbranden CategoryNone => Preprocessor tbl
        Summary[PATCH] [tbl]: tbl.1.man: use neutral wording "decimal separator" in place of English specific "decimal point" and "dot" => [PATCH] [tbl] use term "decimal separator" instead of "decimal point" and "dot"
    2021-11-07 barx Carbon-Copy- => Added keithmarshall
    2021-11-01 gbranden Severity3 - Normal => 2 - Minor
        StatusIn Progress => Fixed
        Open/ClosedOpen => Closed
        Planned ReleaseNone => 1.23.0
    2021-10-31 bjarniig Attached File- => Added tbl.1.man.diff.txt, #52178
    2021-10-31 gbranden StatusNone => In Progress
        Assigned toNone => gbranden
    2021-10-31 barx Carbon-CopyRemoved 93119 => -
    2021-10-31 barx StatusNeed Info => None
    2021-10-28 gbranden StatusNone => Need Info
    2021-10-25 barx Carbon-CopyRemoved 93119 => -
    2021-10-25 barx Summary[PATCH] [tbl]: tbl.1.man: use a neutral wording "decimal separator" in place of English specific "decimal point" and "d => [PATCH] [tbl]: tbl.1.man: use neutral wording "decimal separator" in place of English specific "decimal point" and "dot"

    Back to the top


    Powered by Savane 3.9