bugGNU roff - Bugs: bug #55020, new hdtbl unit test removes...

 
 

bug #55020: new hdtbl unit test removes gdiffmk's unit test on in-tree builds

Submitter:  G. Branden Robinson <gbranden>
Submitted:  Wed 14 Nov 2018 04:18:37 AM UTC
   
 
Category:  Macro - others/general Severity:  3 - Normal
Item Group:  Build/Installation Status:  Fixed
Privacy:  Public Assigned to:  gbranden
Open/Closed:  Closed Planned Release:  1.22.4
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 15 Jun 2022 05:28:30 PM UTC, comment #3: 


commit 09080df0f8895c07f55f36f4835bab0f44dcaa7c
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Tue Nov 13 23:21:14 2018 -0500

    [hdtbl] Don't clean other people's unit tests.

            * contrib/hdtbl/hdtbl.am: test-hdtbl.sh is generated from an .in
            file, so while we can add it to $(TESTS), we shouldn't then add
            $(TESTS) to $(MOSTLYCLEANFILES) or we will clobber all tests
            that ever get defined.  This affected gdiffmk's test script on
            in-tree builds.  Introduce new variable, $(hdtbl_TESTS).  Now
            it clobbers no more.

            Fixes <https://savannah.gnu.org/bugs/index.php?55020>.


G. Branden Robinson <gbranden>
Group administrator
Wed 14 Nov 2018 04:56:05 AM UTC, comment #2: 

Fixed in 09080df0f8895c07f55f36f4835bab0f44dcaa7c.

G. Branden Robinson <gbranden>
Group administrator
Wed 14 Nov 2018 04:20:13 AM UTC, comment #1: 

Except I repeated a literal.  The fix I commit will be improved.

G. Branden Robinson <gbranden>
Group administrator
Wed 14 Nov 2018 04:18:37 AM UTC, original submission:  


./bootstrap
./configure && make -j 3 && make check
make clean
git st
 D contrib/gdiffmk/tests/gdiffmk_tests.sh


Rut-roh.

The fix is straightforward:


diff --git a/contrib/hdtbl/hdtbl.am b/contrib/hdtbl/hdtbl.am
index 2a470967..786c686c 100644
--- a/contrib/hdtbl/hdtbl.am
+++ b/contrib/hdtbl/hdtbl.am
@@ -102,6 +102,7 @@ EXTRA_DIST += \
   contrib/hdtbl/hdtbl.tmac-u \
   contrib/hdtbl/hdmisc.tmac-u

+hdtbl_TESTS = contrib/hdtbl/examples/test-hdtbl.sh
 TESTS += contrib/hdtbl/examples/test-hdtbl.sh
 contrib/hdtbl/examples/test-hdtbl.sh: $(top_builddir)/config.status \
        $(HDTBLPROCESSEDEXAMPLEFILES) $(top_srcdir)/contrib/hdtbl/examples/test-hdtbl.sh.in
@@ -110,7 +111,7 @@ contrib/hdtbl/examples/test-hdtbl.sh: $(top_builddir)/config.status \
                $(top_srcdir)/contrib/hdtbl/examples/test-hdtbl.sh.in > $@
        chmod +x $@

-MOSTLYCLEANFILES += $(TESTS)
+MOSTLYCLEANFILES += $(hdtbl_TESTS)

 # Rule to generate ps and roff files
 SUFFIXES += .roff .in .ps


G. Branden Robinson <gbranden>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gbranden (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-06-15 gbranden CategoryNone Macro - others/general
    2018-11-14 gbranden StatusIn Progress Fixed
        Open/ClosedOpen Closed
        Planned ReleaseNone 1.22.4

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code